Commit Graph
62211 Commits
Author SHA1 Message Date
Kyle BrandtandSam Jewell 3f2ef07872 SSE: Fix goroutine leak in math operation expression parsing (#102380)
---------

Co-authored-by: Sam Jewell <sam.jewell@grafana.com>
2025-03-19 08:34:49 -04:00
Will Assis 216b6e96a9 fix(unified-storage): update instrumentation_server metric gatherer (#102399)
* update instrumentation_server used by the module server to use prometheus gatherer from wire instead of DefaultRegisterer
2025-03-19 08:15:13 -04:00
4eab2ea9d3 Scenes: Implement drag and drop support for SceneCSSGridLayout (#99386)
* Draft: Move css grid stuff to main

* Scenes: Implement drag and drop support for SceneCSSGridLayout

* Fix some nits

* WIP Refactor

* Added a comment

* Add orchestrator to v2schema and fix error (#100964)

* Add orchestrator to v2schema and fix error

* Display placeholder directly when starting to drag

---------

Co-authored-by: kay delaney <kay@grafana.com>

* Fix merge issue

* Fix panel drag offset and remove console.logs

* Fix small nit

* Fix issue where layout options weren't refreshed on changing layout

* Return empty array from useEditPaneOptions if dashboard body isn't LayoutOrchestrator

* Expect layoutOrchestrator when serializing scene

* Fix tests to expect orchestrator instead of layoutManager

* Fix tests in transformSaveModelSchemaV2ToScene.test.ts

* Fix tests in transformSceneToSaveModelSchemaV2.test.ts

* More test fixes

* fix lint issues

* Small fixes

* default to adding layout orchestrator?

* Empty commit

* delete artifactspage.go

* remove artifactspage.tmpl.html

* betterer

* WIP refactor, not ready for review

* Slightly fix placeholder behavior. still broken though

* Fixed some visual glitches. Still very buggy

* Fix layout bugginess when initiating dragging

* more WIP

* Fix some broken logic

* clean up

* Move LayoutOrchestrator to dashboard state

* More cleanup

* Fix misaligned placeholders after changing layout options or resizing browser

* Fix issue with dragging vs selection

* Fix scroll position jumping when dragging in vertically-oriented grid

* Fix import order errors

* Remove '!' from layoutOrchestrator references

* Add LazyLoader support

* Dynamic Dashboards: Responsive Grid drag and drop minor fixes (#102430)

Changes

---------

Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
Co-authored-by: Bogdan Matei <bogdan.matei@grafana.com>
2025-03-19 13:53:58 +02:00
Peter Štibraný 0c58d39e76 Spanner-related fixes (#102376)
* Fix UNION syntax in resourcepermissions package.
* Fix migrations in usermig package to work with Spanner.
* Fix health query.
* Use more connections for integration tests.
* Add test-go-integration-spanner target to run integration tests against Spanner emulator.
* Add test for enterprise.
* Don't delete sequence number for migration_log.id column.

* Only bump max open connections to 20 for Spanner.
Lower integration test timeout.
2025-03-19 12:34:44 +01:00
Alex Khomenko 229f37edb0 Provisioning: Add feature toggle (#102436)
* Provisioning: Add feature toggle

* Provisioning: Use isManagedRepository

* Fix toggle
2025-03-19 12:31:54 +01:00
Gabriel MABILLE 9a556fbde6 AuthZService: Add attributes to traces (#102433) 2025-03-19 12:21:39 +01:00
Jean-Philippe Quéméner 3e3ab8e064 fix(unified-storage): reduce lock contention when pruning (#102425) 2025-03-19 12:15:04 +01:00
Laura Fernández 5a004939da QueryInspector: Show all buttons small screen sizes (#102292) 2025-03-19 12:02:41 +01:00
Torkel Ödegaard a9d81ba605 Dashboard: Switch back to prev layout restores state (#102304) 2025-03-19 10:41:32 +01:00
Matheus MacabuandDana Axinte ac4b2a3200 SecretsManager: Add feature toggle (#102420)
Co-authored-by: Dana Axinte <53751979+dana-axinte@users.noreply.github.com>
2025-03-19 10:25:14 +01:00
xavi 045733aed6 [IAM] Clear user's permission cache after login (#102311) 2025-03-19 10:06:58 +01:00
Mustafa Sencer Özcan ef94d21093 test(unified-storage): Create initial e2e test scenario for unified storage (#102019)
* test: introduce initial e2e test scenario for unified storage

* fix: lint

* chore: trigger build

* test: attach unified storage grpc service into grafana

* fix: lint and todos

* fix: err handling

* chore: trigger build
2025-03-19 09:21:04 +01:00
Matheus Macabu 450d76518e Chore: Remove print from fake service account svc (#102369) 2025-03-19 09:14:26 +01:00
Ivan Ortega Alba 35e3d26987 Dashboards: Do not throw error if backend cannot migrate schemaVersion to latest (#102357)
* Refactor migration error handling to use MinimumVersionError for schema version checks

- Updated migration logic to return MinimumVersionError instead of MigrationError for outdated schema versions.
- Enhanced MinimumVersionError message for clarity on migration constraints.
- Added tests for version error handling in the dashboard API to ensure proper error throwing for specific conversion errors.

* Fix tests and remove folder dependencies
2025-03-19 09:57:05 +02:00
zenador 7f9fa8c662 Grafana UI: Clearly separate multiple warnings by using HTML tags (#97979)
* Allow html in tooltips

* Display multiple warnings/infos properly with html

* Revert "Allow html in tooltips"

This reverts commit 5c7e965d2d554b693d4897e52cf6865e0c9b8374.

* Display multiple warnings/infos properly with html in ReactNode

* Fix lint

* Revise according to code review

* Revise according to code review part 2

* Revise according to code review part 3
2025-03-19 07:05:53 +01:00
Stephanie Hingtgen 6c704484e9 K8s: Add sorting by more than titles (#102403) 2025-03-18 20:23:43 -05:00
owensmallwood ec91ad6db7 Dashboard Provisioning: Dont wait on indexer when nothing deleted (#102390)
* adds debug log

* show dashboard uids as strings

* adds debug log

* don't wait when no deleted dashboards

* adds test
2025-03-18 17:36:10 -06:00
Sam Jewell d7aeebe5e3 Sql Expressions: State when error is from GMS (#102112) 2025-03-18 22:41:42 +00:00
Johnny KartheiserandPepe Cano 671ba2ab02 docs: create documentation for jira service management contact point (#100444)
* docs: create documentation for jira service management contact point

create documentation page for jira service management

* Update configure-jira-service-management.md

updates thanks to yuri and some subsequent edits

* minor edits, weight

minor edits, weight

* links and tables

links and references to jira added on other pages, bullets turned into a table.

* edits

* Update configure-jira.md

link fix

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* pretty, prettier, prettiest

* Update docs/sources/alerting/configure-notifications/manage-contact-points/integrations/configure-jira.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update configure-jira.md

prettier

---------

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>
2025-03-18 15:33:24 -05:00
Haris Rozajac 32756a6c30 Dashboards: Fix time range bug when use_browser_locale is enabled (#102339)
* fix

* update

* fix tests and update
2025-03-18 12:46:22 -06:00
Alexa V defa03b155 Dashboard: Make dashboard scene serializer public (#102384)
Make dashboard scene seralizer public
2025-03-18 11:44:23 -06:00
Alexander Akhmetov a8a88f858a Alerting: Remove uniqueness checks from the Prometheus conversion (#102261) 2025-03-18 18:38:27 +01:00
Alex Khomenko 9988624127 Provisioning: Update getting provisioned meta (#102371) 2025-03-18 20:30:45 +03:00
Yuri Tseretyan 69a62777c5 Fix flaky test TestIntegration_ListDeletedRules (#102383)
Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
2025-03-18 13:28:19 -04:00
Yuri TseretyanandSonia Aguilar e39b17d701 Alerting: Remove constraints for uniqueness of rule title (#102067)
* fix having duplicated names in same group in the UI

---------

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>
2025-03-18 13:27:44 -04:00
Darren JaneczekandLevente Balogh e948376a95 feat: component extension point for adaptive telemetry query actions (#101331)
* feat: component extension point for adaptive telemetry query actions

- only render the first non-null added-component, and provide utility in the added component infrastructure to  support this

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2025-03-18 12:45:01 -04:00
Alex SpencerandLeon Sorokin a7a9f9b078 TimeSeries: Default to single hover point (#102323)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2025-03-18 11:06:10 -05:00
Collin Fingar 23ec5cfcbf ColorPickerInput: Fixed color picker disappearing on input blur (#102241)
* ColorPickerInput: Fixed color picker disappearing on input blur

* Updates per feedback around targeting method

* Updated per feedback - testid vs id
2025-03-18 11:56:32 -04:00
Matheus Macabu 20f9902ed5 CloudMigrations: Remove public preview banner (#102354) 2025-03-18 16:21:16 +01:00
Tom RatcliffeandGilles De Mey b8c627c566 Alerting: Fix display of paused recording rules (#102348)
* Fix display of paused recording rules

* Simplify paused state check for Grafana alert rules

The change eliminates redundant rule type checks by using a more generic
grafana.rule() check that covers both alerting and recording rules.

* Add test for recording rule paused state

* Add test for paused Grafana alert in Details tab

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2025-03-18 14:10:39 +00:00
Alexander Akhmetov 04f20127a2 Revert "Alerting: Add an index to alert_rule_version table on (rule_org_id, rule_uid) (#102347)" (#102368)
This reverts commit 9491fa1895.
2025-03-18 14:54:45 +01:00
Denis Vodopianov 7a01d39025 Chore: Revert Disabling fe-unit-tests github action in release branches (#102361) (#102366)
Revert "Chore: Disabling fe-unit-tests github action in release branches (#102361)"

This reverts commit b28e552a9b.
2025-03-18 14:43:50 +01:00
Georges Chaudy 0bafd4e99d unistore: update spanner ddl to include unistore tables (#102198)
* provision unistore tables

* update the tests to use generated namespace

* update ddl

* update ddl

* clean streams

* missing space

* use engine.db.query
2025-03-18 14:37:11 +01:00
Isabella Siu 8c5a4591fd Cloudwatch: Do not parse log query grouping field to float (#102244) 2025-03-18 09:18:58 -04:00
Ryan McKinley ff6a97f1a1 Provisioning: Update APIs in main (#102345) 2025-03-18 14:55:22 +02:00
Gábor Farkas c28b49e5d1 datasources: querier: single-tenant auth (#102049) 2025-03-18 13:51:49 +01:00
Bogdan Matei 621e7012df Dynamic Dashboards: Fix some of the issues identified during bugbash (#102279) 2025-03-18 14:34:14 +02:00
Beverly Buchanan c5b48285b6 Update roles and permissions doc to include support note (#102327)
add content from support request
2025-03-18 08:30:24 -04:00
Beverly Buchanan b649c8fcd0 Update User API doc to include Cloud info/link (#102330)
* added content per support ticket

* clarified sentece
2025-03-18 08:29:06 -04:00
Denis Vodopianov b28e552a9b Chore: Disabling fe-unit-tests github action in release branches (#102361) 2025-03-18 13:24:45 +01:00
ismail simsek a4d98e465f Chore: Remove dataplane as option from prom converter (#102320)
remove dataplane as option from prom converter
2025-03-18 13:10:22 +01:00
Matheus Macabu 604b7f3a21 CiTools: Bump github.com/expr-lang/expr to silence Dependabot alert (#102358) 2025-03-18 12:34:48 +01:00
Jean-Philippe Quéméner 08994304d8 fix(unified-storage): check resource_api cfg for isHA (#102283) 2025-03-18 12:33:27 +01:00
Konrad LalikandGilles De Mey 321a886b8b Alerting: Add details and edit pages for groups (#100884)
* Add basic details page for groups

* Remove unused imports

* Add basic edit page for groups

* Add functional group details page

* Improve form, add namespaces for DS groups

* Add support for multiple actions in useProduceNewRuleGroup

* Attach real actions to form submit

* Add tests for the group details page

* Add basic tests for the group edit page

* Add tests for Mimir update

* Add rule group consistency check

* Extract draggable rules table to a separate file

* Add prom consistency waiting after group saving

* Add duration measure for Prometheus reconciliation time

* Remove a blinking error when redirecting to a new group

* Improve group details page. Use ruler or prom api depending on the ds capabilities

* Add group delete action for DMA

* Fix GroupDetailsPage tests

* Update tests

* Add and improve Edit page tests

* Add Group export for GMA groups

* Fix RulesGroup tests, add translations

* Disable editing plugin provided groups

* Fix alertingApi options, fix tests

* Fix lint errors, update translations

* use name for grafana managed recording rules

* add namespace to nav

* Remove group modals from the list page

* add cancel button to edit form

* add test for cancel butotn

* fix recording rule badge for Grafana managed rules

* Add doc comments, improve code

* Move url changes to be the last action in form submit

* Add returnTo URL handling for alert rule group navigation

* Create dedicated Title component showing breadcrumb navigation between folder
and group name.

Add label distinction between folders and namespaces based on
the rule source (Grafana vs external).

* Address PR feedback, minor refactorings

* Update rule group links to include return path and refactor rule type checks

- Modified `RulesGroup` and `GroupDetailsPage` components to include `includeReturnTo` in edit page links.
- Refactored rule type checks in `DraggableRulesTable` and `GroupDetailsPage` to use `rulerRuleType` for better clarity and maintainability.
- Updated documentation in `useUpdateRuleGroup` to clarify functionality for updating or moving rule groups.

* Refactor RulesGroup component and tests for improved link handling and permissions checks

- Added `includeReturnTo` parameter to rule group detail links in `RulesGroup` for better navigation.
- Updated test cases to verify rendering of edit and view buttons based on user permissions.
- Simplified test setup by removing unnecessary Redux provider wrapping in tests.

* Refactor: Update routing and test assertions in GroupDetails and GroupEdit pages

- Modified route paths in GroupDetailsPage and GroupEditPage tests to use `dataSourceUid` instead of `sourceId`.
- Updated test assertions to reflect changes in folder title and link structure in GroupDetailsPage.
- Simplified Title component by removing folder-related props and logic, focusing solely on the group name.

* Refactor: Simplify Title rendering in GroupDetailsPage

- Updated the renderTitle function in GroupDetailsPage to remove the folder prop from the Title component, focusing solely on the group name.

* Update GroupDetailsPage to prevent editing of provisioned groups

* Fix imports

* Improve styles

* Fix navigation when served from subpath

* Improve group removal handling in Prom consistency check. Fix Delete group button

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2025-03-18 12:27:53 +01:00
Eric LeijonmarckandGabriel MABILLE fc9e5110d7 Access: Add migration to remove datasources:drilldown (#102188)
* Add migration to remove datasources:drilldown

* remove role assignments as well

* rename to datasources:drilldown

* remove the role assignments

* made it simple instead

* Update pkg/services/sqlstore/migrations/accesscontrol/datasource_drilldown_removal.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

* Update pkg/services/sqlstore/migrations/accesscontrol/datasource_drilldown_removal.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2025-03-18 13:06:30 +02:00
Stephanie Hingtgen c79c768421 Folders: Add pagination to list (#102334) 2025-03-18 04:56:06 -06:00
Oscar Kilhed ba44ceb4b2 Dynamic dashboards: Add paste panel option to add pane (#102350)
* Add paste panel to side pane, unify Store class, subscribe to storage events

* i18n
2025-03-18 11:49:33 +01:00
linomanandIrene Rodriguez afb058c40a Fix URL rendering typo (#102346)
* Fix URL rendering typo

* run prettier

---------

Co-authored-by: Irene Rodriguez <irene.rodriguez@grafana.com>
2025-03-18 11:42:25 +01:00
Alexander Akhmetov 695ac91290 Alerting: Add backend support for keep_firing_for (#100750)
What is this feature?

This PR introduces a new alert rule configuration option, keep_firing_for (Prometheus documentation).

keep_firing_for prevents alerts from resolving immediately after the alert condition returns to normal. Instead, they transition into a "Recovering" state and are not considered resolved by the Alertmanager. Once the recovery period ends (or after the next evaluation if it is bigger than keep_firing_for), the alert transitions to "Normal" if it doesn't start alerting again:

Before                                          

+----------+     +----------+                    
| Alerting |---->|  Normal  |                    
+----------+     +----------+                    

-----
After

+----------+      +------------+     +----------+
| Alerting |----->| Recovering |---->|  Normal  |
+----------+      +------------+     +----------+                                                 

Why do we need this feature?

This feature prevents flapping alerts by adding a recovery period. This helps avoid false resolutions caused by brief alert
2025-03-18 11:24:48 +01:00
Alexander Akhmetov 9491fa1895 Alerting: Add an index to alert_rule_version table on (rule_org_id, rule_uid) (#102347) 2025-03-18 11:15:55 +01:00