Commit Graph
62211 Commits
Author SHA1 Message Date
Stephanie Hingtgen b56db69b32 K8s: Dashboard History: Improve Error Handling (#101816) 2025-03-09 12:19:40 +03:00
Stephanie Hingtgen 9651505cb7 K8s: Dashboards: Fix provisioning (#101844) 2025-03-08 09:37:41 +03:00
Stephanie Hingtgen 473c0b5e89 K8s: Fix plugin updater (#101843) 2025-03-08 02:42:20 +02:00
grafana-pr-automation[bot]andgithub-actions[bot] 4ea290e931 I18n: Download translations from Crowdin (#101751)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-03-08 02:29:28 +02:00
Stephanie Hingtgen bd0c645ff0 K8s: Schema v2: Return 406 in /api (#101842) 2025-03-07 18:20:02 -06:00
Leon Sorokin 1444e9d572 Transformations: Improve groupBy field selection and aggregated field types (#101753) 2025-03-08 01:43:08 +02:00
Drew Slobodnjak f0a8e86c28 Geomap: WebGL for Marker Layer (#95457)
* Geomap: Implement webgl for marker layer

* Cover rgb color formatting

* Adjust size

* Adjust size and leave todo for adjustment

* Add custom icon example

* Use prepareSVG to handle custom icons

* Apply icon offset

* Add example of text labels for fixed case

* Add text canvas layer and layerGroup

* Use textMarker for text layer style

* Fix geometry calcs

* Only include text layer if needed

* Remove extra line

* Move color functions to utils

* Pass webGL bool to marker maker

* Move webgl symbol style to marker maker

* Get hit detection working for webgl layers

* Improve icon hit detection

* Improve text performance

* Fix types and simplify webgl styling

* Simplify webgl regular shape lookup

* Add comments

* Set fallback color to white

* Fix data fit for initial view

* Update color utils to support colors with alpha

* Add tests for color value function

* Add tests for getWebGLStyle function

* Clean up comments

* Only show text if no symbol is specified

* Remove size multiplier from webgl implementation

* Add size multiplier back for now
2025-03-07 13:16:17 -08:00
Isabel Matwawana b26fdf8f5e Docs: traces visualization refactor (#101476)
* Added Config options heading, bumped heading levels, and changed heading

* Updated task sub-heading and added to do notes

* Moved span filter options into a table and moved sentences after table

* Removed image

* Replaced captions with alt text

* Updated image path for main screenshot

* Fixed image path

* Updated screenshot and made to do notes

* Updated link to new heading

* Removed comments
2025-03-07 16:09:44 -05:00
Ezequiel Victorero 1c7f9d4333 Chore: Bump gofpdf (#101823) 2025-03-07 17:40:22 -03:00
Matthew Jacobson 19b878ce66 Alerting: Include time range in template dashboard and panel urls (#101095)
Alerting: Include time range in templated dashboard and panel urls

Time range:
from=Alert.StartsAt-1hr

Firing Alerts: to=Current Timestamp
Resolved Alerts: to=Alert.EndsAt
2025-03-07 15:28:56 -05:00
Jev Forsberg 9be18278d9 Chore: Move code verification to proper workflow (#101742)
* baldm0mma/ move verification to new workflow

* baldm0mma/ test if needs install step

* baldm0mma/ remove install step

* baldm0mma/ update go version
2025-03-07 13:13:40 -07:00
colin-stuart ff10186db7 Docs: Group Attribute Sync feature in private preview (#101822)
* Docs: Group Attribute Sync feature in private preview

* add link & support note

* update GAS API docs
2025-03-07 14:28:26 -05:00
Juan Cabanas 5e21b9e2d1 Invite User: Add invite user button in top bar (#101809) 2025-03-07 16:09:59 -03:00
Matthew Jacobson b73c59547c Alerting: Re-encrypt existing contact points before get and patch in legacy config API (#101263)
* Test covering Get+Save interaction for newly secret fields

* Alerting: Re-encrypt existing contact points before get and patch
2025-03-07 13:26:48 -05:00
Yuri Tseretyan dc75b454f5 Alerting: Improve performance of the setting GUID during migration (#101800) 2025-03-07 12:28:07 -05:00
Torkel Ödegaard 8f6dcd01d6 Dashboard: Editing selection redesign (#101763)
* Dashboard: Editing selection redesign

* Reduce row padding and make it uniform

* Minor tweak

* Update
2025-03-07 17:58:05 +01:00
maicon 8c22459e1f Add debug info for encodeIdentityInMetadata (#101801)
Signed-off-by: Maicon Costa <maiconscosta@gmail.com>
2025-03-07 13:40:09 -03:00
Collin Fingar 8cdc687abf i18n: Marking up Pagination and PageToolbar in Grafana-UI for translation (#101738)
* Grafana-UI: Pagination + PageToolbar i18n

* betterer results update for i18n fix

* Linting fix w/ import order
2025-03-07 11:12:07 -05:00
Alexander Akhmetov 48ea9b08a2 Alerting: Add recording rule target datasource support to Prometheus conversion API (#101799)
What is this feature?

Adds target datasource UID to the recording rules so that they write to the same datasource used for alerting rule queries after the import.

Why do we need this feature?

Target datasourse support was added in #101678, and under a feature flag grafanaManagedRecordingRulesDatasources (#101778).

This PR makes the importing process:
    Check if the import contains recording rules
    Verify both recording rules and the grafanaManagedRecordingRulesDatasources feature flag are enabled
    If either check fails, return an error
    If both checks pass, create recording rules with the provided datasource UID set as both the query and target datasource
2025-03-07 16:56:24 +01:00
owensmallwood 827da46c51 Unified Storage: Remove wildcard queries (#101441)
* WIP adding custom analyzer so we can do substring search efficiently

* Adding unit tests for title search

* formatting

* adds more title search unit tests

* organize helpers

* fixes issue caused by having two title mappings

* Removes camelcase token filter since it prevents you from searching for a substring of chars and numbers. Adds regression test.

* adds back mapping for title_phrase

* use simple analyzer for input query string so it doesn't filter out english stop words

* ran bleve tests, table snapshots updated

* ignore linter for "unused" test functions. They are very helpful for troubleshooting search. Keeping them.

* only log total hits and query cost if result not nil

* fixes failing test - one more field because there are two title mappings now

* fix test

* fixes test - only take first item when its the title

* Adds separate internal field for title ngram mapping.

When searching with a query, results are sorted by score desc.

When searching without a query, results are sorted by title desc.

Adjusts ngram max to be 10.

Text queries are a disjunction of an exact match, phrase match, and a match. Boosted to have priority in that order.

Adds more unit tests for searching.

* linter

* fix test

* ran tests - generated new test dash json

* sort by title phrase instead of title

* fix test - not relying on /apis/dashboard/search to apply title sorting anymore
2025-03-07 09:51:15 -06:00
Gilles De Mey da8f26a07c Alerting: Refactor and clean up rule type guard functions (#101639) 2025-03-07 16:15:55 +01:00
Isabel Matwawana 3a3f781dcf Docs: Add dashboard variables content (#101733)
* Added variables section

* Updated transformations file and Makefile

* Finished Dashboard variables in transformations section
2025-03-07 09:55:39 -05:00
Will Browne 04cc096b23 Docs: Fix plugin installation title by removing non-breaking space (#101798)
remove nbsp
2025-03-07 14:48:55 +00:00
Bogdan Matei 7ee3b9f041 Dynamic Dashboards: Workaround for making responsive items selectable (#101794) 2025-03-07 14:38:08 +00:00
Jean-Philippe Quéméner 2e0d2f3c76 fix(unified-storage): break dependency from dualwriter in resource module (#101788) 2025-03-07 15:27:31 +01:00
Gabriel MABILLE 6a1e5dd128 AuthZ: Test List (#101721)
* Authz: Test List

* Anonymous case

* Cover rendering
2025-03-07 15:01:39 +01:00
Ieva 392124de00 Service Accounts: Don't show error pop-ups for Service Account and Renderer UI flows (#101776)
* don't show error pop-ups for SAs and renderer

* only hide non 4xx error pop'ups

* linting
2025-03-07 13:37:26 +00:00
Steve SimpsonandAlexander Akhmetov 14ebec527c Alerting: Allow selection of recording rule write target on per-rule basis. (#101778)
* Alerting: Allow selection of recording rule write target on per-rule basis.

Introduces a new feature flag (`grafanaManagedRecordingRulesDatasources`),
disabled by default, to enable the ability to write recording rules data using
data source settings, and selecting the data source to use on a per-rule basis.

To cope with the scenario of users upgrading, a configuration file option
allows setting the default data source to use, if none is specified in the rule,
emulating the behaviour of recording rules without the flag enabled.

* Lint

* Update conf/sample.ini

Co-authored-by: Alexander Akhmetov <me@alx.cx>

---------

Co-authored-by: Alexander Akhmetov <me@alx.cx>
2025-03-07 14:30:40 +01:00
Matheus Macabu 5917ed8227 Hackaton: Add more unit tests, take 4 (#101704)
* cloudmigration/cloudmigrationimpl: run integration tests in parallel

* tsdb/mysql: run tests with actual service and instance manager

* pluginsintegration/angulardetectorsprovider: reduce job interval in test

* util: extract test that should only be ran with -race enabled and unskip it
2025-03-07 14:06:47 +01:00
Steve Simpson cc80681beb Alerting: Extend recording rules test to exercise writing with data sources. (#101775)
The change to use WriteDatasource was done in a previous commit, this adds a
test case using DatasourceWriter, in addition to the one using PrometheusWriter.
2025-03-07 13:51:50 +01:00
Will Assis 6544674011 fix(unified-storage): Fix dualwriter DELETE mode3 not returning error from legacy (#101728)
* Fix dualwrite package not returning error when getting a non-not found error from legacy storage in mode
2025-03-07 07:04:59 -05:00
Ieva f0d260ba5b Service Accounts: Don't show error pop-ups for Service Account and Renderer UI flows (#101679)
don't show error pop-ups for SAs and renderer
2025-03-07 11:38:15 +00:00
Alexander Akhmetov 0fa2dbdcdc Alerting: Generate deterministic UID for folders created for Prometheus rule conversion (#101760) 2025-03-07 12:09:39 +01:00
Misi d3b3186713 Auth: Make ssoSettingsSAML GA and enabled by default (#101766)
Make ssoSettingsSAML GA and enabled by default
2025-03-07 12:01:18 +01:00
56b030492f Update make docs procedure (#101497)
Co-authored-by: grafanabot <bot@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2025-03-07 10:38:11 +00:00
Mariell HoversholmandMatheus Macabu 5ef3400115 CI: Report to bench (#101686)
* feat: report to bench

* fix: output json

* chore: own the code

* temp: limit files to test for faster iteration

* temp: force bench to run for testing purposes

* fix: bench has been merged to main

* fix: correct file name

* temp: remove temp

* feat: pin the tparse binary

Co-authored-by: Matheus Macabu <macabu@users.noreply.github.com>

---------

Co-authored-by: Matheus Macabu <macabu@users.noreply.github.com>
2025-03-07 11:07:56 +01:00
Tobias Skarhed cf95a42507 ScopesContext: Move export from unstable to regular entrypoint (#101765)
Revert unstable export
2025-03-07 11:40:40 +02:00
renovate[bot] 0d32ba4d43 Update scenes to v6.2.1 (#101722)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-07 11:38:20 +02:00
Steve Simpson 872fbf0208 Alerting: Implement arbitrary data source remote writer. (#101735)
* Alerting: Implement arbitrary data source remote writer.

Recording rules currently remote write to the endpoint speficied in the
configuration file, but we want to change this so that it can be specified
on a per-rule basis. This change implements the updated RemoteWriter
interface, and dispatches writes to the correct data source.

Notes about the implementation:
- There is a defaulting behaviour, because we will need to handle situations
  when upgrading from older Grafana versions, where recording rules do not a
  data source target specified.
- In order to avoid re-creating the remote write clients for every request,
  a cache is used. The entries have a TTL of 30 seconds at which point they
  are recreated; this is the delay for picking up new data source settings.

Known limitations:
- There is no per data source configuration for the remote write path suffix.
- Not all data source settings will be used, but basic auth and TLS will be.
- There is no RBAC. This will be a follow up feature.

* Lint
2025-03-07 10:23:23 +01:00
Ryan McKinleyandClarity-89 f52b6a5a42 Provisioning: Update spec and dependencies (#101746)
Co-authored-by: Clarity-89 <homes89@ukr.net>
2025-03-07 10:57:13 +03:00
Alexander Akhmetov aa5f2e43d4 Alerting: Use upsert to set or update provenance (#101688)
Alerting: Use upsert to update provenance
2025-03-07 08:36:14 +01:00
df3e58cb11 docs: alert rule history (#100378)
* docs: alert rule history

first draft

* -additional h2, removal of compare functionality

-additional h2, removal of compare functionality

* Update docs/sources/alerting/monitor-status/view-alert-rules.md

Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>

* Update docs/sources/alerting/monitor-status/view-alert-rules.md

Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>

* Update docs/sources/alerting/monitor-status/view-alert-rules.md

Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>

* Update view-alert-rules.md

added image

* update frontmatter description

* prettier

* Update view-alert-rules.md

* Update view-alert-rules.md

---------

Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>
Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
2025-03-06 18:03:17 -06:00
Stephanie Hingtgen c8278a88c2 Revert "K8s: Fix plugin updater" (#101739)
Revert "K8s: Fix plugin updater (#101646)"

This reverts commit 605a4cbff9.
2025-03-06 23:07:52 +02:00
Sarah Zinger ab56ac515d DS-Querier: Hopefully fix and debug cases where query data response is nil (#101729) 2025-03-06 15:30:06 -05:00
Adela Almasan 3e910015dc Chore: Deprecate actions prop from context menu (#101535) 2025-03-06 14:12:39 -06:00
Jev Forsberg ef3cb8596e Chore: Backend unit test workflow (#101534)
* baldm0mma/ parallelize tests for reporting

* baldm0mma/ update combining non-existant outputs

* baldm0mma/ remove duplicate logic

* baldm0mma/ rem any unnecessary logging

* baldm0mma/ add workflow path for test coverage test

* baldm0mma/ cache ent

* baldm0mma/ update with crucial comments

* baldm0mma/ generate go files

* baldm0mma/ cache enterprise only once

* baldm0mma/ adjust coverage threshholds

* baldm0mma/ remove temp artifacts from storage to save $$$

* baldm0mma/ remove strict coverage for unit tests

* baldm0mma/ pass coverage go opts

* baldm0mma/ update run backend tests action to composite

* baldm0mma/ separate make gen go into it's own composite step

* baldm0mma/ move options to workflow

* baldm0mma/ remove use of action

* baldm0mma/ remove unsed action

* baldm0mma/ update codeowners

* baldm0mma/ add edition logic

* baldm0mma/ set env vars in determine-edition action

* baldm0mma/ make test

* baldm0mma/ debug sequential

* baldm0mma/ debugging by removing unit tests

* baldm0mma/ TRY SOMETHING DIFFERENT!!!

* baldm0mma/ uploading ent from within the workspace

* baldm0mma/ revert run-backend-tests action

* baldm0mma/ move edition to job level

* baldm0mma/ update WIRE_TAGS

* baldm0mma/ move the enterprise code to the correct location after extracting it

* baldm0mma/ rem packaging/extracting of enterprise code

* baldm0mma/ test makefile

* baldm0mma/ add ent setup to coverage

* baldm0mma/ rem backend test action

* baldm0mma/ add wire and go steps to coverage job

* baldm0mma/ remove make installation, as it is already present in the "ubuntu-latest" package

* baldm0mma/ convert to matrix testing strategy

* baldm0mma/ update separate test coverage to only a day

* baldm0mma/ add setup-common-backend-testing-env action

* baldm0mma/ add setup env

* baldm0mma/ update naming

* baldm0mma/ updade codeowners

* baldm0mma/ rem ent

* baldm0mma/ update naming

* baldm0mma/ remove multiline syntax in report-coverage

* baldm0mma/ make gen-go

* baldm0mm/ remove integration tests

* baldm0mma/ update coverage params

* baldm0mma/ streamline workflow

* baldm0mma/ update codeowners

* baldm0mma/ update naming

* baldm0mma/ simplify logic

* baldm0mma/ remove uneeded trigger

* baldm0mma/ remove conditional coverage step

* baldm0mma/ debug coverage

* baldm0mma/ update file name

* baldm0mma/ remove artifact upload

* baldm0mma/ update atrifact params in the workflow

* baldm0mma/ simplify processing logic
2025-03-06 12:27:04 -07:00
c7b0bbd262 Azure: Variable editor and resource picker improvements (#101695)
* Update namespace endpoint to filter out only relevant namespaces

* Update tests

* Fix url builder tests

* Add todo comments

* Update func to use ARG to retrieve namespaces with metrics

* Refactor getMetricNamespaces for readability

* Lint

* Remove comments

* Remove type assertion

* Refactor ARG query

* Update tests and refactor class to use ARG

* Update resource group query

- Updates the resource groups query to support users/apps with restricted permissions

* Update resources request to be paginated

- Also order by name
- Add tests

* Start refactoring azure monitor util functions to resource graph

* Minor lint

* Add getMetricNamespaces resource graph function

* Modify getMetricNamespaces call

- Use resource graph function for variable queries

* Return names for getResourceNames values

* Use getMetricNamespaces variable specific req in editor

* Substantial refactor

- Update Azure Resource Graph data source with a method for making paged requests and a method for retrieving metric namespaces (and add tests)
- Extract helpers from azure_monitor_datasource to utils and generalise them (also revert previous changes to datasource and test file)
- Update mock with Azure Resource Graph data source
- Revert response parser changes
- Revert url builder changes
- Update get metric namespaces query to use the resource graph method for variable queries
- Update docs

* Lint

* Oops

* Fix type

* Lint and betterer

* Simplify imports

* Improve type

* Simplify resource picker class

* Start updating tests

* Fix naming and include missing error

* Update resource graph data source mock

* Update tests

* Remove unneeded parser

* Add get subscriptions to resource graph

* Generalise resource groups request

* Fix resource names request to ensure no clashing

* Update types

* Use resource graph queries for resource picker

* Correctly map resource group names

* Update mocks

* Update tests

* Fix mapping

* Refactor getResourceNames

- Remove most of the logic from resourcePickerData
- Add helper for parsing resource names as template vars
- Some renames for clarity
- Update types
- Update tests

* Ensure namespaces are lowercase

* Update docs/sources/datasources/azure-monitor/template-variables/index.md

Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>

* Prettier write

* Ensure we return all namespaces if resourceGroup isn't specified

---------

Co-authored-by: alyssabull <alyssabull@gmail.com>
Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>
2025-03-06 21:08:35 +02:00
colin-stuart 32624b3251 Tests: skip failing test TestMigrateToSpannerDialect (#101730)
skip failing test TestMigrateToSpannerDialect
2025-03-06 20:47:37 +02:00
Alyssa (Bull) Joyner 4c5a906c83 Azure Monitor: Filter namespaces by resource group (#100325) 2025-03-06 11:41:24 -07:00
Alexa VandHaris Rozajac 53de9ea795 Dashboard: SchemaV2 - arbitrary strings - dual key (#100379)
* Create element panel lookup table

* When transforming to schema v2 get the element_identifier

* Add element identifier logic to layouts

* Retrieve element id in the serialization of each layout

* Keep ElementMapping updated when adding, removing panels

* Add basic unit test

* Wip: implement element mapping in serializer

* Remove Singleton

* Apply suggestions from code review

Co-authored-by: Haris Rozajac <58232930+harisrozajac@users.noreply.github.com>

* bring back missing functions - poc works at this point

* Move getElementIdentifierForVizPanel to dashboardSceneGraph

* poc - don't keep elementMapping updated

* Move logic to layout type serializer

* Remove unused code and remove layout tests

* clean up code, remove unnecessary functions

* Fix issue with initializeMapping

* remove console errors

* Remove testing code from response transformers

* Add unit test for DashboardSceneSerializer

* reset file, change not needed

* Improve comments on getElementIDForPanel

---------

Co-authored-by: Haris Rozajac <58232930+harisrozajac@users.noreply.github.com>
2025-03-06 19:59:27 +02:00