Commit Graph
40837 Commits
Author SHA1 Message Date
Marco Schaefer 08acfafffd Upgrade faro-core and faro-web-sdk to 1.0.2 (#64407) (#64695)
* chore: upgrade faro-core and faro-web-sdk to 1.0.2 (#64407)

With v1.0.2 Faro explicitly closes fetch requests.
This fixes an issue were (headless) chrome browser
still considers those requests as open  which lead to timeouts.

(cherry picked from commit d8a497ee6e)

* fix: add missing setView and getView mocks
2023-03-14 11:05:10 +02:00
Grot (@grafanabot)andAlexander Weaver fc8002d9ab [v9.4.x] Alerting: Log error but don't fail initialization if state history connection test fails (#64719)
Alerting: Log error but don't fail initialization if state history connection test fails (#64699)

Don't return init error if ping fails, add tests

(cherry picked from commit faef3a8258)

Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>
2023-03-13 23:59:21 +02:00
Grot (@grafanabot)andKristina 75a44af935 [v9.4.x] Dashboards: Filter out expressions when going to Explore (#64684)
Dashboards: Filter out expressions when going to Explore (#64654)

* Filter out expressions when going from dashboard to explore

* Move expression UID constant to types

(cherry picked from commit c363a81806)

Co-authored-by: Kristina <kristina.durivage@grafana.com>
2023-03-13 08:23:53 -05:00
Grot (@grafanabot)andWilliam Assis 53a06bf65f [v9.4.x] Frontend: Fix broken links in /plugins when pathname has a trailing slash (#64608)
Frontend: Fix broken links in /plugins when pathname has a trailing slash (#64348)

Fix broken links in /plugins when pathname has a trailing slash

(cherry picked from commit a05cb1e78e)

Co-authored-by: William Assis <35489495+gassiss@users.noreply.github.com>
2023-03-13 13:53:13 +01:00
Grot (@grafanabot)andAshley Harrison 7a26957f87 [v9.4.x] Navigation: Remove duplicate header on user invite page (#64678)
Navigation: Remove duplicate header on user invite page (#64677)

remove duplicated header in old navigation

(cherry picked from commit caf98101e7)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-03-13 13:53:54 +02:00
Grot (@grafanabot)andAshley Harrison d75b8c13ef [v9.4.x] TimeSeries: fix time comparer not comparing date strings properly (#64674)
TimeSeries: fix time comparer not comparing date strings properly (#64622)

* fix time comparer not comparing times properly

* move isDateTime last as it's probably the most expensive check

(cherry picked from commit 3a1862f37f)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-03-13 05:43:31 -04:00
Grot (@grafanabot)andBrendan O'Handley 01917df71a [v9.4.x] InfluxDB: Fix type assertion panics for interface conversion: interface {} is nil (#64623)
InfluxDB: Fix type assertion panics for interface conversion: interface {} is nil (#64556)

* fix type assertions

* fix chk

* add nil and fix tests

* add test for null bool and strings in the JSON response to be parsed as nil in Go

* reduce complexity

* reduce complexity

* reduce complexity again

* switch case for valTypes

(cherry picked from commit 50ef183208)

Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com>
2023-03-10 14:51:52 -05:00
Grot (@grafanabot)andKevin Yu b7ff4d1661 [v9.4.x] Cloudwatch Logs: Fix log group names not interpolating with multiple variables (#64631)
Cloudwatch Logs: Fix log group names not interpolating with multiple variables (#64567)

* Cloudwatch Logs: Fix log group names not interpolating with multiple variables

* fix test

(cherry picked from commit 75f89e67af)

Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
2023-03-10 14:12:28 -05:00
Timur Olzhabayev eaace4fc45 [v9.4.x] Docs: Minor wording changes for plugin signing docs (#64615) (#64624)
Docs: Minor wording changes for plugin signing docs (#64615)

Minor wording changes

(cherry picked from commit f9b9041ad8)
2023-03-10 09:51:13 -08:00
Grot (@grafanabot)andJack Baldry 039d9c379c [v9.4.x] Update page labels to better reflect contents (#64626)
Update page labels to better reflect contents (#64606)

* Set correct products labels on Grafana Cloud and Enterprise pages

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Add cloud label to all alerting docs

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit 72e50431df)

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2023-03-10 17:47:45 +00:00
Grot (@grafanabot)andTimur Olzhabayev 6bce4d516d [v9.4.x] Docs: Changes to angular deprecation announcement (#64619)
Docs: Changes to angular deprecation announcement (#63928)

Adjusting the content to reflect latest discussions. This page can now be used as reference for all things about angular deprecation.

(cherry picked from commit 9ca53d9596)

Co-authored-by: Timur Olzhabayev <timur.olzhabayev@grafana.com>
2023-03-10 17:47:45 +01:00
Grot (@grafanabot)andIda Štambuk 332e870086 [v9.4.x] Cloudwatch: Add expression field to interpolate variables in Metrics Code Builder (#64508)
Cloudwatch: Add expression field to interpolate variables in Metrics Code Builder (#64288)

(cherry picked from commit 1c8ad04f8d)

Co-authored-by: Ida Štambuk <ida.stambuk@grafana.com>
2023-03-10 15:02:07 +01:00
Grot (@grafanabot) 6f22584d26 [v9.4.x] Alerting: fix users call 403 by calling /user instead of /users/{id} (#64607)
Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
fix users call 403 by calling /user instead of /users/{id} (#64544)
2023-03-10 14:29:43 +01:00
Grot (@grafanabot)andSantiago 961446e7e1 [v9.4.x] Docs: Remove Alertmanager configuration rollback from What's New (#64588)
Docs: Remove Alertmanager configuration rollback from What's New (#64564)

* Docs: Remove Alertmanager configuration rollback from What's New

* Trigger Build

---------

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit d21d498142)

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
2023-03-10 10:04:15 -03:00
Grot (@grafanabot)andSonia Aguilar 419e8d782c [v9.4.x] Alerting: Fix contact point name being URL-encoded in the title (#64596)
Alerting: Fix contact point name being URL-encoded in the title (#64590)

Fix contact point name being encoded in the title text

(cherry picked from commit 4c8855ed2d)

Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>
2023-03-10 06:29:52 -05:00
Ashley Harrison aa09499343 Backport 62658 to v9.4.x (#64545)
* Navigation: Fix Home logo always going to `/login` (#62658)

* only redirect to /login when anonymous access is disabled

* only search for dashboards when not logged in if anon access is enabled

* fix go logic

* add unit tests

(cherry picked from commit 3336327306)

* remove file i accidentally left in :/

* import correct method
2023-03-10 04:59:06 -05:00
Grot (@grafanabot)andTania cf3f234a54 [v9.4.x] Docs: Add a note on uploading report branding logos (#64539)
Docs: Add a note on uploading report branding logos (#64532)

* Docs: Add a note on uploading report branding logos

* Fix wording

(cherry picked from commit 6f67529a0a)

Co-authored-by: Tania <yalyna.ts@gmail.com>
2023-03-09 10:53:37 -05:00
Grot (@grafanabot)andDimitris Sotirakis de7d18d4e0 [v9.4.x] CI: Add PrereleaseBucket field in versions.go (#64524)
CI: Add `PrereleaseBucket` field in `versions.go` (#64519)

Add PrereleaseBucket in versions.go

(cherry picked from commit 29b3f3fbf4)

Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com>
2023-03-09 17:49:59 +02:00
Horst Gutmann 7f6c61f0bd [9.4.x] CI: Move some build settings (#64491) (#64513)
CI: Move some build settings (#64491)

* Move some build settings to Vault

* CI: Remove reference to DOWNSTREAM_REPO as it isn't used

(cherry picked from commit 4b241804b4)
2023-03-09 08:33:15 -05:00
Grot (@grafanabot)andDominik Prokop 47e1860e34 [v9.4.x] OptionsPicker: Correctly highlight template variable value when filtering (#64394)
OptionsPicker: Correctly highlight template variable value when filtering (#63495)

* VariablePicker: Correctly highlight items when filtering

* Change interactions for selecting values in variable options picker

* Review

(cherry picked from commit e4d591fc01)

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2023-03-09 04:21:16 -08:00
Grot (@grafanabot)andSven Grossmann db9dfc7aef [v9.4.x] Loki: Fix labels in LabelBrowser being wrongly cached (#64496)
Loki: Fix labels in LabelBrowser being wrongly cached  (#64482)

* remove label cache from label browser

* fix spelling

Co-authored-by: Gareth Dawson <gareth.dawson@grafana.com>

---------

Co-authored-by: Gareth Dawson <gareth.dawson@grafana.com>
(cherry picked from commit 976568a337)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2023-03-09 05:43:50 -05:00
George Robinsonandbrendamuir 0d561b6c24 [v9.4.x] Docs: Updates default template link (#64495)
Docs: Updates default template link (#64485)

Updates default template link

(cherry picked from commit 14208c4c42)

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2023-03-09 05:21:48 -05:00
Grot (@grafanabot)andGeorge Robinson 9bccf165be [v9.4.x] Docs: Last iteration on docs for images in notifications (#64494)
Docs: Last iteration on docs for images in notifications (#64392)

This commit includes some minor rephrasing to the Requirements and
Limitations of the Images in notification feature.

(cherry picked from commit 1898e76dd6)

Co-authored-by: George Robinson <george.robinson@grafana.com>
2023-03-09 05:03:44 -05:00
Grot (@grafanabot)andIsabella Siu 936e72f1e6 [v9.4.x] CloudWatch Logs: Fix interpolation of scoped variables in queryString (#64405)
* CloudWatch Logs: Fix interpolation of scoped variables in queryString (#64267)

(cherry picked from commit af9a0dbe39)

* fix typecheck

---------

Co-authored-by: Isabella Siu <Isabella.siu@grafana.com>
2023-03-08 19:56:07 -05:00
Brendan O'Handley b66e903439 Prometheus: Metric encyclopedia (#63423) (#64455)
* add metric encyclopedia feature toggle and component

* remove unused button

* move file, add test file

* add tests

* add pagination and tests

* test with 10,000,000 metrics

* remove unused import

* add filter by type

* search alphabetically and add switch to exclude metrics with no metadata

* add suggested functions and filter for functions

* allow user to select variables in encyclopedia

* fix style and tests

* add fuzzy search by either metric name or all metadata

* if missing metadata, remove metadata fuzzy search option, exclude metadata, and filter by type

* add encyclopedia feature tracking

* indicate that metrics are filtered by labels

* handle metric singular or plural

* add tooltips and fix language

* add filtering tests

* change 'search' to 'browse'

* remove functions filter and tests as not part of work flow

* add m.e. button and selected metric is a tag

* fix hanging search and update styles, padding, labels, and groupings

* small performance improvements

* fix tests

* add backend metrics query option

* add loading spinner for start load and backend search

* autofocus search input

* Update docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* run prettier

* run prettier

* fix text for feature toggle

* for license check since https://cla-assistant.io/check/grafana/grafana?pullRequest=<PR#> is not working

* fixing tests

* fix feature toggle docs

* fix feature toggle

* fix feature toggle

* add owner to feature toggle

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
(cherry picked from commit 9b6e531549)
2023-03-08 13:47:05 -05:00
Grot (@grafanabot)andStephanie Hingtgen 2911eec518 [v9.4.x] Plugins: Fix bug with copying grafanaData (#64454)
Plugins: Fix bug with copying grafanaData (#64446)

(cherry picked from commit 39a4634ae9)

Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com>
2023-03-08 13:40:21 -05:00
Grot (@grafanabot)andSofia Papagiannaki ea660e188e [v9.4.x] Snapshots: Fix deleting snapshot with non existent dashboard ID (#64371)
Snapshots: Fix deleting snapshot with non existent dashboard ID (#64345)

* Add test for deleting snapshot for non existent dashboard

* Add test for failure to fetch guardian other than ErrDashboardNotFound

* Fix dashboard snapshot delete

(cherry picked from commit 43095d84e4)

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
2023-03-08 03:33:23 -05:00
Grot (@grafanabot)andBrendan O'Handley 3b523c13a7 [v9.4.x] OpenTSDB: Allow metric autocomplete to use suggest api on every input (#64361)
OpenTSDB: Allow metric autocomplete to use suggest api on every input (#62045)

* allow metric autocomplete by suggest api

* debounce sugggest metrics

* debounce sugggest metrics with debounce-promise

* commit for tests

(cherry picked from commit 70c1850888)

Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com>
2023-03-07 18:02:26 -05:00
Grot (@grafanabot)andKevin Yu 4474649869 [v9.4.x] Cloudwatch Logs: Make mixed type fields fallback to being strings (#64359)
Cloudwatch Logs: Make mixed type fields fallback to being strings (#63981)

* Cloudwatch Logs: make mixed type fields fallback to being strings

* addressing pr comments

(cherry picked from commit 70f600db10)

Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
2023-03-07 17:57:12 -05:00
Grot (@grafanabot)andAlexander Weaver 772eb4b58a [v9.4.x] Alerting: Fix intermittency when seeding database in rule store tests (#64326)
Alerting: Fix intermittency when seeding database in rule store tests (#64322)

Force unique IDs when seeding database

(cherry picked from commit 4a1c18abf6)

Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>
2023-03-07 11:00:50 -05:00
Grot (@grafanabot)andIvana Huckova 9e0cb259ee [v9.4.x] Logs sample: Fix scrolling for unwrapped log lines (#64291)
Logs sample: Fix scrolling for unwrapped log lines (#64163)

Fix scrolling for logs sample

(cherry picked from commit 7b01668729)

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-03-07 12:34:38 +01:00
Grot (@grafanabot)andGeorge Robinson e272ce8274 [v9.4.x] Docs: Update Images in notifications docs to be more readable and instructive (#64294)
Docs: Update Images in notifications docs to be more readable and instructive (#64227)

(cherry picked from commit 9d9421154e)

Co-authored-by: George Robinson <george.robinson@grafana.com>
2023-03-07 10:58:29 +00:00
Will Browne 2d0324ec70 [v9.4.x] Plugins: Fix Cache-Control header response for public/plugins/* assets API (#64255)
resolve conflicts
2023-03-06 19:20:54 +01:00
Galen Kistler 5a6471c01f TimeSeries: Fix overflowing exemplar modals causing content shifts (#… (#64254)
TimeSeries: Fix overflowing exemplar modals causing content shifts (#64037)

*  fix overflowing exemplar modals causing content shifts

(cherry picked from commit b9ebd5757a)
2023-03-06 12:18:05 -06:00
Grot (@grafanabot)andGeorge Robinson 0d2a01f03f [v9.4.x] Alerting: Fix Classic Conditions $values variable (#64249)
Alerting: Fix Classic Conditions $values variable (#64243)

This commit fixes a bug in the $values variable in notification
templates when using Classic Conditions. Since Classic Conditions
are not multi-dimensional, the values of each series that exceeded
the condition should be available as a RefID and offset. For example,
B0, B1, etc. However, this bug meant that instead just a single
condition would be printed as B, not B0.

(cherry picked from commit ed71012ced)

Co-authored-by: George Robinson <george.robinson@grafana.com>
2023-03-06 12:33:30 -05:00
Alexander Weaver 4c38e25ecd Alerting: Expose Prometheus metrics for persisting state history (#64246)
Alerting: Expose Prometheus metrics for persisting state history (#63157)

* Create historian metrics and dependency inject

* Record counter for total number of state transitions logged

* Track write failures

* Track current number of active write goroutines

* Record histogram of how long it takes to write history data

* Don't copy the registerer

* Adjust naming of write failures metric

* Introduce WritesTotal to complement WritesFailedTotal

* Measure TransitionsFailedTotal to complement TransitionsTotal

* Rename all to state_history

* Remove redundant Total suffix

* Increment totals all the time, not just on success

* Drop ActiveWriteGoroutines

* Drop PersistDuration in favor of WriteDuration

* Drop unused gauge

* Make writes and writesFailed per org

* Add metric indicating backend and a spot for future metadata

* Drop _batch_ from names and update help

* Add metric for bytes written

* Better pairing of total + failure metric updates

* Few tweaks to wording and naming

* Record info metric during composition

* Create fakeRequester and simple happy path test using it

* Blocking test for the full historian and test for happy path metrics

* Add tests for failure case metrics

* Smoke test for full annotation persistence

* Create test for metrics on annotation persistence, both happy and failing paths

* Address linter complaints

* More linter complaints

* Remove unnecessary whitespace

* Consistency improvements to help texts

* Update tests to match new descs

(cherry picked from commit 19d01dff91)
2023-03-06 12:10:11 -05:00
Grot (@grafanabot)andSven Grossmann 52288b87aa [v9.4.x] LokiContextUi: Add loading indicator (#64244)
LokiContextUi: Add loading indicator (#64167)

add loading indicator to LokiContextUi

(cherry picked from commit 5db0d14606)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2023-03-06 17:38:35 +01:00
Grot (@grafanabot)andGilles De Mey 84e358660a [v9.4.x] Revert "Alerting: Fix alert form broken coming from panel (#64148)" (#64241)
Revert "Alerting: Fix alert form broken coming from panel (#64148)" (#64240)

(cherry picked from commit 282d021c53)

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-03-06 10:39:46 -05:00
Grot (@grafanabot) 269ae0d7be [v9.4.x] Alerting: Fix queries not being previewed in detail view (#64235)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Fix queries not being previewed in detail view (#64198)
2023-03-06 09:58:52 -05:00
Grot (@grafanabot)andGilles De Mey 24e46f3ae7 [v9.4.x] Alerting: Disable "Declare Incident" button for open-source editions (#64234)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-03-06 09:58:48 -05:00
Grot (@grafanabot)andUladzimir Dzmitračkoŭ 232cbed853 [v9.4.x] GrafanaUI: reset ConfirmModal disabled state on re-open (#64207)
GrafanaUI: reset ConfirmModal disabled state on re-open (#63452)

(cherry picked from commit 88231c7cb8)

Co-authored-by: Uladzimir Dzmitračkoŭ <3773351+going-confetti@users.noreply.github.com>
2023-03-06 13:33:44 +01:00
Grot (@grafanabot)andVictor Marin c5583207ee [v9.4.x] Fix scenario where tooltip shows wrong value (#64199)
Fix scenario where tooltip shows wrong value (#64025)

* Fix scenario where tooltip shows wrong value

* refactor

(cherry picked from commit 211a999a2a)

Co-authored-by: Victor Marin <36818606+mdvictor@users.noreply.github.com>
2023-03-06 11:54:25 +00:00
Giordano Ricci c48ca77815 [v9.4.x] Explore: Avoid changing queries twice when importing a query in mixed mode (#64206)
Explore: Avoid changing queries twice when importing a query in mixed mode (#63804)

* Explore: avoid changing queries twice when importing a query in mixed mode

* move logic to thunk

* add tests

* improve tests

(cherry picked from commit 24a4a24a89)
2023-03-06 11:33:39 +00:00
Dimitris Sotirakis 5fb2986aa5 [v9.4.x] Chore: Bump alpine version to 3.17.1 (#63252) (#63264)
Chore: Bump alpine version to `3.17.1` (#63252)

Bump alpine version to 3.17.1

(cherry picked from commit 24c60486f6)

# Conflicts:
#	.drone.yml
2023-03-06 04:40:47 -05:00
Sonia Aguilar 6772c060d8 Alerting: Fix alert form broken coming from panel (#64148) (#64200)
Fix alert form broken coming from panel

(cherry picked from commit a669b72641)
2023-03-06 04:14:33 -05:00
f918b3bf9d [v9.4.x] Alerting: Prevent resetting the form on evaluation group interval change (#63794)
Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-03-06 10:00:00 +01:00
Grot (@grafanabot)andTimur Olzhabayev 49ef18b2b7 [v9.4.x] Docs: Adding angular support deprecation to our plugin submission FAQ (#64201)
Docs: Adding angular support deprecation to our plugin submission FAQ (#64006)

Adding angular support deprecation to our faq

(cherry picked from commit 43e281271b)

Co-authored-by: Timur Olzhabayev <timur.olzhabayev@grafana.com>
2023-03-06 03:57:18 -05:00
Grot (@grafanabot)andchrisharbro f80239c21a [v9.4.x] update data source permissions instructions to match modern UI (#64181)
update data source permissions instructions to match modern UI (#63405)

* update data source permissions instructions to match modern UI

* Apply suggestions from code review

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
(cherry picked from commit adc8000b72)

Co-authored-by: chrisharbro <102977229+chrisharbro@users.noreply.github.com>
2023-03-03 16:26:27 -06:00
Grot (@grafanabot)andchrisharbro bf6e7d2abe [v9.4.x] Clarify that LDAP will create Grafana users by default when they log in for the first time (#64180)
Clarify that LDAP will create Grafana users by default when they log in for the first time (#63391)

* Clarify that enabling LDAP will create users by default when they log in

This proposed change to the doc was requested by a user in support ticket `79860`, as it was not clear to them that the OOTB behavior was for user accounts to be provisioned automatically in Grafana when signing in for the first time via LDAP.

* Update docs/sources/setup-grafana/configure-security/configure-authentication/ldap/index.md

Thanks!

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* fix boolean

Woops, `true` should be `false`

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
(cherry picked from commit b136d0dfcf)

Co-authored-by: chrisharbro <102977229+chrisharbro@users.noreply.github.com>
2023-03-03 16:26:04 -06:00
Jack Baldry ddf5363aa6 [v9.4.x] Replace ambiguous relrefs with partial URIs to prevent 404s (#62468) (#64114)
* Replace ambiguous relrefs with partial URIs to prevent 404s



* Fix local builds that depend on latest content



* Fix broken relref



---------


(cherry picked from commit 66b54e2dbd)

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
2023-03-03 18:59:09 +00:00