Commit Graph

15811 Commits

Author SHA1 Message Date
Sonia Aguilar 3450d243b9 Alerting: Delete permanently deleted alert rules. (#102960)
* add alertingDeletePermanently ff

* add delete permanently button in Recently deleted page

* use ff to protect delete permanent button column

* update transations and prettier

* invalidate tag and update transalations keys

* add test

* prettier

* refactor test

* restore wrong change in deleteRulerRuleGroupHandler

* update test

* linter

* Alerting: Permanent delete rules code review (#103288)

* Update feature toggle name and description

* Rename mutation endpoint

* Fix typo and update text to be "permanently delete"

* Update feature toggle and test

* Move delete button into actions column

* generate ff

* address feedback

---------

Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
2025-04-03 14:18:25 +03:00
Sven Grossmann f277902682 Sidebar: Create a sidebar that can render an extension (#102626)
* Extension Sidebar: Add missing `web-section` icon

* Extension Sidebar: Add core extension sidebar components

* Extension Sidebar: Integrate extension sidebar into Grafana

* Extension Sidebar: Change extension point to alpha

* Extension Sidebar: Fix saved state of docked extensions

* Extension Sidebar: Delete from local storage if undocked

* Extension Sidebar: Move main scrollbar from body to pane

* Extension Sidebar: Expose `ExtensionInfo`

* Extension Sidebar: Move `useComponents` into ExtensionSidebar

* Extension Sidebar: Store selection in `localStorage`

* Extension Sidebar: Simplify return of extension point meta

* Extension Sidebar: Ensure `body` is scrollable when sidebar is closed

* Extension Sidebar: Add missing `GlobalStyles` change

* Extension Sidebar: Don't render `ExtensionSidebar` unless it should be open

* Extension Sidebar: Better toggle handling

* Extension Sidebar: Fix wrong header height

* Extension Sidebar: Change `getExtensionPointPluginMeta` to use `addedComponents` and add documentation

* Extension Sidebar: Add tests for `getExtensionPointPluginMeta`

* Extension Sidebar: Add tests for `ExtensionSidebarProvider`

* Extension Sidebar: Fix tests `ExtensionSidebarProvider`

* Extension Sidebar: Add tests `ExtensionToolbarItem`

* Extension Sidebar: Add `extensionSidebar` feature toggle

* Extension Sidebar: Put implementation behind `extensionSidebar` feature toggle

* update feature toggles

* fix lint

* Extension Sidebar: Only toggle if clicking the same button

* Extension Sidebar: Hide sidebar if chromeless

* Update feature toggles doc

* Sidebar: Add `isEnabled` to ExtensionSidebarProvider

* Extension Sidebar: Use conditional CSS classes

* Extension Sidebar: Move header height to GrafanaContext

* Sidebar: Adapt to feature toggle change

* Sidebar: Remove unused import

* Sidebar: Keep featuretoggles in ExtensionSidebar tests

* ProviderConfig: Keep `config` import in tests

* FeatureToggles: adapt to docs review

* fix typo
2025-04-03 12:16:35 +02:00
Stephanie Hingtgen b97b1cc730 K8s: Revert change around full path (#103334) 2025-04-03 04:57:26 -05:00
Jean-Philippe Quéméner f4ae8516bd chore(folders): add extended tracing to the folders service (#103007) 2025-04-03 11:54:47 +02:00
Alexander Akhmetov b49c532999 Alerting: Fix state transition from Recovering back to Alerting (#103286)
What is this feature?

This PR fixes a state transition issue where alerts transitioning from the Recovering state back to the Alerting state incorrectly entered the Pending state first if the rule had a For duration configured.

Why do we need this feature?

When an alert goes from Alerting to Recovering (when using the Keep firing for) and then back to Alerting, the existing logic would incorrectly put the alert into Pending state while it should be alerting and still sending notifications to the Alertmanager.
2025-04-03 11:40:45 +03:00
Matheus Macabu 7165bc553a CloudMigrations: Add Cypress happy path test case scenarios (#103250) 2025-04-03 10:34:32 +02:00
Stephanie Hingtgen 4918d8720c Dashboard Restore: Remove experimental functionality under feature flag dashboardRestore for now - this will be reworked (#103204) 2025-04-03 02:52:54 -05:00
Will Assis db1f1c5df9 search: add manager kind to bleve (#103305) 2025-04-03 10:02:02 +03:00
Ryan McKinley 5dad2b6c0f Provisioning: Write finished job to history before delete (#103328) 2025-04-03 10:00:44 +03:00
Isabella Siu 6a699b69ba AWS: Add flag for multitenant temp credentials (#103307) 2025-04-02 16:25:50 -04:00
Yuri Tseretyan dc0083d879 Alerting: Sequential evaluation of rules in group (#98829)
* introduce RulesGroupComparer

* extract runJob method

* implement sequential evaluation

* Make sequence building testable & add comments

* Also run callback in recording rules + add tests

* Improve tests

* Address PR comments

---------

Co-authored-by: William Wernert <william.wernert@grafana.com>
2025-04-02 23:10:32 +03:00
Todd Treece ba5c38b078 K8s: Remove new context from client (#103069) 2025-04-02 14:59:54 -04:00
Kevin Minehart 88d54892bd CI: Move e2e test pipeline from Drone to GitHub Actions (#103134)
* Add e2e dagger pipeline

* various-suite not various suite

* upload videos dir

* produce e2e videos even on failure

* nil ref

* sync doesn't return container

* fix quotes

* try without flags first?

* try without quoting?

* use two dashes in flags

* update CODEOWNERS

* make update-workspace

* go work sync

* make update-workspace

* add newline
2025-04-02 13:31:47 -05:00
Andreas Christou 47ec51fda7 Influx: Support PDC for Influx SQL (#103032)
* Support PDC for Influx SQL

* Correctly set the gRPC transport creds dial option

* Logging and refactor

* Allow URLs with no scheme

* Use passthrough resolver for socks proxy

* Update comment

* Extract url parsing and add test

* Check err
2025-04-02 16:21:59 +01:00
Alyssa (Bull) Joyner 3b73ebb210 Azure Monitor: Add logs query builder (#99055) 2025-04-02 08:15:25 -06:00
Sven Grossmann a67cb174c7 Investigations: add fieldConfig and queries (#103276)
* Investigations: add `fieldConfig` and `queries`

* fix openAPI
2025-04-02 15:42:32 +02:00
Kyle Brandt c6e52c4766 SQL Expressions: Make SQL Expressions work with Alerting (#101820)
Initial support for alerting with SQL expressions

- When `format` is set to `alerting`, SQL expressions output in a format suitable for alerting evaluation.
- Outstanding TODOs:
  - Deduplicate output rows
  - Add more tests
  - Fix broken alerting UI rendering (likely due to shape change to undocumented full-long format)
- Basic usage:
  - SQL must return one numeric column and one or more string columns.
  - Each row may become an alert.
  - The alert fires if the numeric value is non-zero.
  - String columns are treated as labels.

---------

Co-authored-by: Konrad Lalik <konradlalik@gmail.com>
Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
Co-authored-by: Sam Jewell <sam.jewell@grafana.com>
2025-04-02 09:39:36 -04:00
mohammad-hamid 192d3783d5 Zanzana/enable TLS for client side gRPC (#103000)
* zanzana - add tls to the client

* remove todo

* gofmt

* adjust comment
2025-04-02 09:12:58 -04:00
beejeebus 360c57b3d7 InfluxDB: capture more downstream errors (#103274)
This adds more checks on the type of errors returned from InfluxDB fsql
datasource queries. Grpc errors with code `InvalidArgument`, `PermissionDenied`
and `NotFound` are mapped to downstream errors.
2025-04-02 08:47:47 -04:00
Ryan McKinley c54496a3f9 Search: Avoid panic with missing title (#103257) 2025-04-02 15:43:08 +03:00
Yulia Shanyrova 332f041c91 Chore: Promote pluginsDetailsRightPanel to general availability (#103269)
Chore: Promote pluginsDetailsRightPanel to general availability and deafult
2025-04-02 14:34:18 +02:00
Will Assis 08042ae827 search: add legacy id for all resources in bleve (#103206)
* add legacy id for all resources in bleve
2025-04-02 08:20:23 -04:00
Kyle Brandt 856dcfd6fe SQL Expressions: Permit range conditions (between) in queries (#103238) 2025-04-02 15:13:17 +03:00
Vardan Torosyan 26eab9981a Return correct disabled status when looking up a user (#103182) 2025-04-02 13:38:10 +02:00
Roberto Jiménez Sánchez aaa61d0919 Provisioning: Fix push to PR branch (#103262)
* Fix push to PR branch

* Fix original screenshot generation
2025-04-02 14:17:33 +03:00
Andres Martinez Gotor f1e214261c Chore: Allow for an applink to set a subtitle (#103205) 2025-04-02 12:43:21 +02:00
Matheus Macabu d5addcc822 Chore: Fix Go Workspace Check workflow and run make update-workspace (#103261)
* Chore: Fix Go Workspace Check workflow

* Chore: Run make update-workspace
2025-04-02 12:26:38 +02:00
Gábor Farkas 135fbf6258 data sources: feature toggle: route explore queries to the new query service (#103192)
* data sources: route explore queries to the new query service

* prettier fix

* easier to read logical statement
2025-04-02 12:00:33 +02:00
Eric Leijonmarck 1c07fd3d4f feat: add ft and add datasource:explore to viewers for viewers_can_edit (#103251)
* feat: add ft and add datasource:explore to viewers for viewers_can_edit

* removed the feature toggle

* remove file
2025-04-02 12:25:42 +03:00
Matheus Macabu 93009a4f5b Dependencies: Fix invalid version for pkg/apis/folder (#103256)
* Chore: Use correct version of pkg/apis/folder

* Chore: Clarify pinning for google/cel-go

* Remove replace directives

---------

Co-authored-by: leonorfmartins <leonorfmartins@gmail.com>
2025-04-02 11:23:59 +02:00
Ryan McKinley 34192e3ad0 Provisioning: Support migrate to local (#103247) 2025-04-02 11:25:06 +03:00
Ryan McKinley 6781612335 Provisioning: Enable search when provisioning is enabled (#103208) 2025-04-02 11:20:28 +03:00
Roberto Jiménez Sánchez 0aeefedb0c Provisioning: Snapshot original dashboard (#103170)
Snapshot original dashboard
2025-04-02 10:12:42 +02:00
Leonor Oliveira f21362ad48 Convert pkg/apis/folder to a module (#102975)
* Convert pkg/apis to a module

* Update apistore module to use apis go module

* Add module to dependabot

* Group go dependencies

* Add guidelines for adding a new gomod

* Prettier

* Only convert apis/folder to a module for now

* Add replace directive

* Add missing go mod
2025-04-02 10:10:04 +02:00
Roberto Jiménez Sánchez 04e152f326 Provisioning: webhook last event timestamp (#103180)
* Record webhook pinged event

* Add TODO for webhook creation updated

* Hack to wire client

* Revert accidental change in controller

* Wire the client

* Use factory method

* Remove omit empty

* Regenerate client

* Fix compilation

* Every 30 seconds if not pinged

* Move lines around

* Use different approach

* Added as part of the controller

* Exponential backoff for waiting for ping

* More stuff

* Revert changes in controller

* Add separate webhook section in overview

* Change order of translations

* Update ping within 1 minute

* Last event update

* Extract translation

* Display last event in frontend

* Refactor the logic around update

* Fix the type to marshal
2025-04-02 10:09:58 +02:00
maicon d8c5c2d3b8 K8s: Folders: Modify GetChildren to return only Folder References (#103072)
* Return FolderReference instead of Folder on GetChildren

Signed-off-by: Maicon Costa <maiconscosta@gmail.com>

---------

Signed-off-by: Maicon Costa <maiconscosta@gmail.com>
2025-04-02 01:30:17 -03:00
Alexander Akhmetov 7347083f98 Alerting: Validate target datasource type only when importing recording rules (#103214) 2025-04-01 20:28:10 +02:00
Stephanie Hingtgen 5535447587 Folders: Change query to an inner join on dashboards rather than 2 gets (#103183) 2025-04-01 21:21:58 +03:00
Ryan McKinley 9c49c601f1 Unistore: Add generation column (#102222) 2025-04-01 20:38:23 +03:00
Gabriel MABILLE 2d89b16d7e Tracing: Add Insecure to NewOTLPTracingConfig (#103174) 2025-04-01 17:34:42 +02:00
Ryan McKinley f087d5f61b Provisioning: validate files we read (#103197) 2025-04-01 17:49:08 +03:00
Isabella Siu 1aea65f6d5 X-Ray: Add toggle for application signals (#103054)
X-Ray: add toggle for application signals
2025-04-01 10:42:02 -04:00
Timur Olzhabayev 5098015467 Chore: Enable external core plugins feature toggle by default (#102209)
* Turning externalCorePlugins on by default

* enable externalCorePlugins feature toggle by default

* fixing generated toggles ts
2025-04-01 17:00:44 +03:00
Kyle Brandt 9358a557ee Graphite: Add frame type to work with SQL expressions (#103019)
- Add frame type So SQL expressions knows how to convert it
- No FrameType version so how other expressions do not change how they handle it, and continue to catch the special graphite handling in SSE convert
2025-04-01 09:43:36 -04:00
Andres Martinez Gotor 8f0b2d9fd5 Chore: Enable Grafana version check when installing plugins (#103176) 2025-04-01 15:35:09 +02:00
Timur Olzhabayev 03c894489c Chore: Enabling failWrongDSUID by default in Grafana 12 (#102192)
* enabling failWrongDSUID by default in Grafana 12

* making reviewdog happy

* generating feature toggle files
2025-04-01 14:59:32 +02:00
Alex Hunsaker fa8dafec77 Tempo: fix streaming with TLS without BasicAuth (#100546)
Fixes #100545

Streaming queries/metrics do not work if TLS is enabled and basic auth is not.

"Save & test" while adding/editing a tempo datasource throw `e.data is undefined` in the ui.

Gafana server logs report:

> logger=grafana-apiserver t=2025-02-12T17:55:29.131036665Z level=info msg="[core] [Channel #42 SubChannel #43]grpc:
> addrConn.createTransport failed to connect to {Addr: \"tempo:3200\", ServerName: \"tempo:3200\", }. Err: connection
> error: desc = \"error reading server preface: read tcp 127.0.0.1:55432->127.0.0.1:3200: read: connection reset by
> peer\""

> logger=grafana-apiserver t=2025-02-12T17:55:36.835523455Z level=info msg="[core] [Channel #31 SubChannel #32]grpc:
> addrConn.createTransport failed to connect to {Addr: \"tempo:3200\", ServerName: > \"tempo:3200\", }. Err: connection
> error: desc = \"error reading server preface: EOF\""

Fix by using TLS when enabled regardless of basic auth settings.

Co-authored-by: André Pereira <adrapereira@gmail.com>
2025-04-01 13:41:22 +01:00
Joey 4689b7c0cd TraceView: Add scope attributes to span details (#103173)
* Add scope attributes to span details

* Tests
2025-04-01 13:26:16 +01:00
Sam Jewell af08a9fae2 SQL Expressions: Add JSON support (#103157)
- Support bi-directional mapping of frame JSON fields and GMS (go-mysql-server) columns 
- Permit GMS json functions

Co-authored-by: Kyle Brandt <kyle@grafana.com>
2025-04-01 07:45:01 -04:00
Ryan McKinley 6754781d7b Provisioning: Remove unnecessary flags from tests and instructinos (#103165) 2025-04-01 13:43:00 +03:00