Commit Graph
42344 Commits
Author SHA1 Message Date
64ee42d01e Alerting: Add limits and move state and label matching filters to the BE (#66267)
* WIP

* Add instance totals to combined rule. Use totals to display instances stats in the UI

* WIP

* add global summaries, fix TS errors

* fix useCombined test

* fix test

* use activeAt from rule when available

* Fix NaN in global stats

* Add no data total to global summary

* Add totals recalculation for filtered rules

* Fix instances totals, remove instances filtering from alert list view

* Update tests

* Fetch alerts considering filtering label matchers

* WIP - Fetch alerts appending state filter to endpoint

* Fix multiple values for state in request being applyied

* fix test

* Calculate hidden by for grafana managed alerts

* Use INSTANCES_DISPLAY_LIMIT constant for limiting alert instances instead of 1

* Rename matchers parameter according to API changes

* Fix calculating total number of grafana instances

* Rename matcher prop after previous change

* Display button to remove max instances limit

* Change matcher query param to be an array of strings

* Add test for paramsWithMatcherAndState method

* Refactor matcher to be an string array to be consistent with state

* Use matcher query string as matcher object type (encoded JSON)

* Avoind encoding matcher parameters twice

* fix tests

* Enable toggle for the limit/show all button and restore limit and filters when we come back from custom view

* Move getMatcherListFromString method to utils/alertmanager.ts

* Fix limit toggle button being shown when it's not necessary

* Use filteredTotals from be response to calculate hidden by count

* Fix variables not being replaced correctly

* Fix total shown to be all the instances filtered without limits

* Adress some PR review comments

* Move paramsWithMatcherAndState inside prometheusUrlBuilder method

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>
2023-04-25 11:19:20 +02:00
Ivan Ortega Alba 44035ecbb2 Advanced DS Picker open Connections page when toggle is enabled (#67139) 2023-04-25 10:42:04 +02:00
Ivan Ortega Alba 4d474e8e4f Fix icon size for data source picker list item (#67144) 2023-04-25 10:41:31 +02:00
Sofia Papagiannaki 7dbcd5ecd0 NestedFolders: Return full folder hierarchy in Folder response (#66835)
* Delete redundant struct

* Include parent folders in DTO

* Add test

* Update swagger
2023-04-25 11:22:20 +03:00
Joey 5c2a344ce1 Traces: Order keys in span filter select (#66689)
* Order logs keys last

* Add tests
2023-04-25 08:56:06 +01:00
Sofia Papagiannaki 3bc002cd27 API: Add add deprecation notice for getting folder by sequential ID (#67091)
* API: Add deprecation notice

* Update Swagger/openAPI
2023-04-25 10:33:47 +03:00
Josh Hunt 1324434dfb Datagrid: Fix untyped code (#67148) 2023-04-25 09:26:12 +03:00
Alexander Weaver 117636e8ca Alerting: Fix panic when reparenting receivers to groups following an attempted rename via Provisioning (#67167) 2023-04-24 21:23:23 -04:00
Adela Almasan 1a347bfb7b Timeseries: Revert annotations rendering changes (#67166) 2023-04-24 15:38:30 -07:00
matt abrams cd205e3f46 Update index.md (#64783)
fix typo
2023-04-24 12:38:00 -10:00
Galen Kistler 57d3027cb0 Prometheus: Default cache value in UI doesn't match functional default (#67159)
* add disabled state style, set correct default value to match default functionality
2023-04-24 15:24:12 -05:00
Adela Almasan c4c747cca6 e2e: Update annotation marker selector (#67135) 2023-04-24 18:51:15 +00:00
Galen Kistler a6577cc6fd Revert "Prometheus: Add Victoria metrics to Prometheus type dropdown in datasource config" (#67150)
Revert "Prometheus: Add Victoria metrics to Prometheus type dropdown in datasource config (#66984)"

This reverts commit 7cb4d65584.
2023-04-24 12:59:27 -05:00
Kyle Brandt e57e0769ca Prometheus: Enable prometheusDataplane by default (#67100)
* Prometheus: Enable prometheusDataplane by default
and related mitigation toggle dataplaneFrontendFallback
original PRs with the toggles:
 - https://github.com/grafana/grafana/pull/65237
 - https://github.com/grafana/grafana/pull/62694
2023-04-24 20:29:54 +03:00
Ashley Harrison dcf53dbb3b ConfirmModal: make button styling consistent (#67142)
* stop using fill="outline" for confirm modal dismiss button

* kick drone
2023-04-24 17:53:28 +01:00
Steve Simpsonandgotjosh 9effb9a708 Alerting: Allow hooking into request handler functions. (#67000)
* Alerting: Allow hooking into request handler functions.

Adds a facility to AlertNG for hooking into API handlers, allowing the
replacement of request handlers for specific paths. One of goals of this
approach was to allow hooking as late as possible in the request, e.g.
after all middleware has been applied, to simplfiy usage.

* Update pkg/services/ngalert/api/hooks.go

Co-authored-by: gotjosh <josue.abreu@gmail.com>

* Update pkg/services/ngalert/api/hooks.go

Co-authored-by: gotjosh <josue.abreu@gmail.com>

* Update pkg/services/ngalert/ngalert.go

Co-authored-by: gotjosh <josue.abreu@gmail.com>

* Fixes to review comments

* Fix passing logger in

---------

Co-authored-by: gotjosh <josue.abreu@gmail.com>
2023-04-24 18:18:44 +02:00
Kevin Yu 68a277b53b CloudWatch: Add field level comments to schema (#66900)
* CloudWatch: Add field level comments to schema

* update comments

* pr comments

* remove unneeded test
2023-04-24 08:57:39 -07:00
Ashley Harrison 4e492ae725 Navigation: Unify Page component (#66951)
* remove old page component

* add test to check initDashboard is only called once (prevent variables loading twice)

* add help node

* update unit tests

* remove last mentions of topnav

* fix unit tests

* remove unused props from ButtonRow interface

* remove prop from test
2023-04-24 16:41:32 +01:00
Ivana Huckova 67ca91ece3 Loki: Fix incorrect evaluation of real and extracted labels in context (#67112)
* Loki: Fix incorrect evaluation of real/extracted labels in context

* Add tests

* Improve caching and add more tests

* Use mockResolvedValue

* Flip logic for getInitContextFiltersFromLabels

* Update to logic to use fetchSeriesLabels for queries with more than 1 parser
2023-04-24 17:36:30 +02:00
Josh Hunt 69e5a2bdf9 NestedFolders: Basic search view (#67093)
* First stab and reusing SearchView for new Browse Dashboards

* NestedFolders: Basic SearchView

* last bits of cleanup
2023-04-24 18:32:04 +03:00
Ivana Huckova 2fb1c64e80 Loki: Enable new log context query editor (#67131)
Loki: Enable new log context editor
2023-04-24 17:27:43 +02:00
Ivana Huckova e2e243d1b6 Elasticsearch: Fix processing of duplicated metric types and field (#66973)
* Elasticsearch: Fix processing of duplicated metric types and field

* Fix lint

* Fix linting
2023-04-24 17:26:04 +02:00
Jack Baldry 3c655821e8 Update make-docs script (#66841)
Update centralized make-docs procedure

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
2023-04-24 16:23:33 +01:00
Esteban Beltran 872e79f687 Toolkit: Remove plugin:dev and plugin:test (#67125) 2023-04-24 17:18:42 +02:00
Esteban Beltran 362936b002 Build: Force same version of @emotion/react via webpack config (#66822) 2023-04-24 17:13:52 +02:00
Ivana Huckova 0b2f7db224 Elasticsearch: Deprecate index setting for annotation queries (#67046)
* Elasticsearch: Deprecate index setting for annotation queries

* Update comment
2023-04-24 17:02:55 +02:00
Victor MarinandTorkel Ödegaard efd0e9cbea Datagrid Panel: Edit data within your dashboards (#66353)
* wip

* Datagrid WIP: snapshotting when data edited, better UI for adding column/rows, refactors

* wip

* WIP

* wip

* Add series selector

* Delete selection on key press

* wip

* Multiple row select and delete

* wip

* draggable rows/columns, better column width calculator

* bug fixes

* scrollbars

* add feature flag

* bugfixes

* bugfixes

* bugfixes

* bugfixes

* Add possibility to rename column

* Input fixes

* bugfixes

* bugfixes

* performance optimisations

* WIP component refactoring and optimisations

* comment bit of code to remove error for testing

* fix column move and payload types

* WIP refactors and tests

* e2e tests

* queryGroup subscription refactor

* queryGroup - add component on update, fix failing tests

* refactor querygroup

* querygroup refactor

* tests

* fix codeowners validation

* lint fixes

* revert convertFieldType modification in favor of already merged mod + re-add mistakenly deleted line

* remove //ts-ignores

* Minor style tweaks

* fix

* align colors with theme

* fixes

* refactor

* add test for convertFieldType transformer and write todo

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-04-24 17:46:31 +03:00
Brendan O'Handley c5ea3cd7e0 Prometheus: remove part of flaky e2e test (#67116)
remove elements of flaky e2e test

This test only checks 'undo' in the code editor and then checks if the query builder is present. The test is timing out when looking for the query builder. There should be a second test to check if undo works in the query builder so I'm removing the query builder check. I will add an issue to create a test for 'undo' in the query builder.
2023-04-24 10:28:57 -04:00
Arati RandSofia Papagiannaki fd434cab58 NestedFolders: Add API endpoint for descendant count in a folder (#66550)
* Add CountInFolder to RegistryService interface
* Add folder children counts api route
* Update fake GetFolderChildrenCounts
* Add test for getting folder children counts
* Add validation to folder children counts handler
* Update openapi specs
* Update pkg/services/folder/folderimpl/folder.go
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

---------

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
2023-04-24 15:57:28 +02:00
Andre Pereira 990b3c07ab Tempo: Add kind to TraceQL intrinsics (#65111)
* Add kind to TraceQL intrinsics

* Fix after merging main

* Fix intrinsics array reference after merge

* Dispatch error message when TraceQL autocomplete fails to retrieve tag values
2023-04-24 14:11:28 +01:00
BrunoandChristopher Moyer d4715a6f04 CSRF middleware: Add flag to skip login cookie check (#66806)
* CSRF middleware: add flag to skip login cookie check

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-04-24 10:11:08 -03:00
Sarah Zinger 5f16cd5124 Cloudwatch Logs: Clarify Cloudwatch Logs Limits (#67072)
Clarify Cloudwatch Logs Limits
2023-04-24 08:47:29 -04:00
Bruno 86be40555f Chore: use native async fs.readFile in json-file-to-job-output script (#66686) 2023-04-24 09:46:56 -03:00
brendamuir 2521fa9448 Docs: Fixes alert rule type table (#67090)
* Fixes alert rule type table

* adds responsive table markdown

* adds responsive table

* updates image text

* Adds word breaks

* fix responsive table
2023-04-24 13:48:57 +02:00
Laura Fernández 07373705d9 Grafana UI: Improve AutoSaveField component (#66751) 2023-04-24 12:42:42 +02:00
Ieva cd8f6a59b9 Docs: add support bundle section to the config snippet (#67059)
add support bundle section to the config snippet
2023-04-24 11:38:58 +01:00
Torkel Ödegaard af9bf81102 AppChrome: Fix scrollbar issue for small (mobile) breakpoint (#67058) 2023-04-24 10:52:12 +02:00
Torkel Ödegaard 94cf94ff68 AppNotificationList: Improves position now that topnav is live (#66959)
* AppNotificationList: Improves position now that topnav is live

* update pos
2023-04-24 10:20:47 +02:00
Alexander Zobnin 28a641aa50 Authentication UI: Fix permissions for saving settings (#67086)
Fix permissions for saving settings
2023-04-24 09:57:05 +02:00
Torkel ÖdegaardandCarl Bergquist 57701fd2f2 ServeFromSubPath: Redirect to URL with subpath when subpath missing (#66724)
* ServeFromSubPath: Redirect to URL with subpath when subpath missing

* Review fixes

* Added tests

* Use constant

* change to useMiddleware

* Update pkg/middleware/subpath_redirect.go

---------

Co-authored-by: Carl Bergquist <carl.bergquist@gmail.com>
2023-04-24 09:55:55 +02:00
Gábor Farkas 2767d5b1c2 devenv: loki: improved fake data generation (#66966) 2023-04-24 07:50:39 +00:00
Konrad LalikandGilles De Mey 91704cf7de Alerting: Loki-based alert state history modal (#66595)
* adds alertstatehistory backend config to grafanaBootData

* add alertStateHistory api

* show different ASH modal when using loki implementation

* group log lines by instance (unique set of labels)
Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com>

* render log lines for each instance
Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com>

* Add visual improvements to the log record of state changes

* Add values to log records

* compute common labels and show unique labels

* Add state changes visualization

* fix common labels extraction

* Code cleanup

* Add timespan-based log record view

* WIP

* scroll to timestamp - poc

* Use SortedVector for timestamp field

* add conditional accessor for frames

* update some of the log formats and styles

* Timestamp-based visualization with scrolling

* minor improvements

* Split Loki's state history viewer into multiple files

* Add memoization to prevent graph rerender on filter updates

* make chart size shrink when fewer instances

* style updates

* show warning when instances are hidden

* Add basic label-based filtering

* Improve label-based filtering

* Add regex validation

* Improve no instances message when everything was filtered out

* Update warning message

* Move timeline viewer to a separate file, refactor handling timeline pointer changes

* Remove unused component, add comments

* Fix test snapshot, fix type error

* adds tests for common.ts

* Add tests for converting log records into data frames

* Add basic component test, fix type guards

* Use a constant for timeseries limit

* Improve a11y, update component test

* Memoize AlertStateTag, migrate from deprecated ArrayVector

* Update public/app/features/alerting/unified/components/rules/state-history/common.ts

* Move helper hook into a separate file. Add Search input component

* Change the limit of visible time series on the timeline

* Add LogRecordViewer perf improvements, refactor timeline cursor events tracking

* Use callback to pass timeline refs

* Add grouping tests for the log record viewer

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-04-24 09:28:11 +02:00
Agnès Toulet fe5a07f336 Rendering: Fix panel rendered count on error (#67027)
Rendering: fix panel rendered count on error
2023-04-24 09:27:49 +02:00
Gabriel MABILLE 9c6feac6cc FIX: Make dashboards navlink accessible with only folders permissions (#67049) 2023-04-24 09:02:42 +02:00
Ivana HuckovaandJ Stickler 24c754334f Loki: Update content for log context ui (#66978)
* Loki: Update content for context ui

* Update

* Update public/app/plugins/datasource/loki/components/LokiContextUi.tsx

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update public/app/plugins/datasource/loki/components/LokiContextUi.tsx

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update public/app/plugins/datasource/loki/components/LokiContextUi.tsx

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update public/app/plugins/datasource/loki/components/LokiContextUi.tsx

Co-authored-by: J Stickler <julie.stickler@grafana.com>

---------

Co-authored-by: J Stickler <julie.stickler@grafana.com>
2023-04-22 14:07:44 +02:00
Shirley d120c05608 CloudWatch: Fix test on metric stat editor statistic field (#67064) 2023-04-22 11:28:34 +02:00
Adela Almasan b992bdb62d Annotations: Avoid crash when listing panels (that are rows) (#66869) 2023-04-21 23:50:45 +03:00
faad4b92ad GrafanaDS: Add support for annotation time regions (#65462)
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
2023-04-21 23:25:50 +03:00
Andreas Christou a2b97547a6 AzureMonitor: Correct series name accounting for dimensions (#67050)
Correct displayName accounting for dimensions
2023-04-21 19:24:23 +01:00
Ezequiel Victorero 0b246942ae PublicDashboards: Remove flaky test (#67061) 2023-04-21 14:46:27 -03:00