Commit Graph
44514 Commits
Author SHA1 Message Date
Will Browne 72da44db0e Plugins: Add validation stage to plugin loader pipeline (#73053)
* first pass

* change validation signature

* err tracking

* fix

* undo golden

* 1 more

* fix

* adjust doc

* add test helper

* fix linter
2023-08-09 18:25:28 +02:00
Yuri TseretyanandMatthew Jacobson 69c8200fc9 Alerting: Add more tests for state manager ProcessEvalResults (#73019)
Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>
2023-08-09 12:21:12 -04:00
arunkg2787 cda78c6fe8 Update _index.md (#72562)
Fixes # https://github.com/grafana/support-escalations/issues/6887

Configure HA: Added ha_peer_Timeout global config in the unified alerting
2023-08-09 17:53:57 +02:00
779e0fe311 Feature Toggles: Create API for updating feature toggle state from the feature toggle admin page (#73022)
* create roles for writing feature toggles

* create update endpoint / handler

* api changes

* add feature toggle validations

* hide toggles based on their state

* make FlagFeatureToggle read only

* add username log

* add username string

* refactor for better readability

* refactor unit tests so we can do more validations

* some skeletoning for the set tests

* write unit tests for updater

* break helper functions out

* update sample ini to match defaults

* add more logic to ReadOnly label

* add user documentation

* fix lint issue

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

---------

Co-authored-by: IbrahimCSAE <ibrahim.mdev@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
2023-08-09 11:32:28 -04:00
Gilles De Mey d9695eb507 Alerting: Add "no-rules" to redirect to rule viewer (#73111) 2023-08-09 17:17:41 +02:00
Karl PerssonandJo e53e22ef2a Contexthandler: Remove code that is no longer used (#73101)
* Contexthandler: remove dead code

* Contexthandler: Add tests

* Update pkg/tests/api/alerting/api_alertmanager_test.go

Co-authored-by: Jo <joao.guerreiro@grafana.com>

---------

Co-authored-by: Jo <joao.guerreiro@grafana.com>
2023-08-09 15:17:59 +02:00
JoandIeva 5d8e6aa162 Auth: Org Invite and Team API SignedInUser interfacing (#73085)
* fix ngalert Evaluate sig change

* interface for teams and org invites

* Update pkg/api/org_invite.go

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

---------

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
2023-08-09 12:33:35 +02:00
Sven Grossmann 1343c74362 Logs: Disable query splitting due to conflicts with transformations (#73086)
* disable query splitting for now

* change stage of `lokiQuerySplitting`
2023-08-09 13:21:38 +03:00
Jo 97ba611e4c Chore: Fix ngalert Evaluate signature change (#73084)
fix ngalert Evaluate sig change
2023-08-09 11:27:14 +02:00
JoandIeva bd1a856d33 Auth: Add SignedIn user interface NamespacedID (#72944)
* wip

* scope active user to 1 org

* remove TODOs

* add render auth namespace

* import cycle fix

* make condition more readable

* convert Evaluate to user Requester

* only use active OrgID for SearchUserPermissions

* add cache key to interface definition

* change final SignedInUsers to interface

* fix api key managed roles fetch

* fix anon auth id parsing

* Update pkg/services/accesscontrol/acimpl/accesscontrol.go

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

---------

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
2023-08-09 09:35:50 +02:00
Karl Persson 144e4887ee Auth: Use authn.Service for all tests (#72921)
* Dashboards: Fix tests when authn broker is enabled.
StarService was not configured for tests, the call was guarded by !c.IsSignedIn

* Change default to be anon user to match expectations from tests

* OAuth: rewrite tests to work with authn.Service

* Setup template renderer by default

* Extract cookie options from cfg instead of relying on global variables

* Fix test to work with authn service

* Middleware: rewrite auth tests

* Remvoe session cookie if we cannot refresh access token
2023-08-09 08:54:52 +02:00
Clément Duveau 5eef8291e2 Add a warning in the documentation (#72975)
A partner complained in the name of a customer. They have 6k datasources and it took them some time to figure out why they only had 5k coming back.

This commit add a warning for this edge case, content is pretty clear.
2023-08-08 14:15:45 -07:00
Konrad Lalik df3d10606d Alerting: Optimize rule details page data fetching (#72977) 2023-08-08 20:36:38 +02:00
Andrej OcenasandVictor Marin 15ac12637d Table: Add storybook and docs for custom render cell type (#72619)
* Add storybook and docs for custom rendering cell

* Update packages/grafana-ui/src/components/Table/Table.mdx

Co-authored-by: Victor Marin <36818606+mdvictor@users.noreply.github.com>

---------

Co-authored-by: Victor Marin <36818606+mdvictor@users.noreply.github.com>
2023-08-08 19:02:48 +02:00
Yuri Tseretyan 6b4a9d73d7 Alerting: Export contact points to check access control action instead legacy role (#71990)
* introduce a new action "alert.provisioning.secrets:read" and role "fixed:alerting.provisioning.secrets:reader"
* update alerting API authorization layer to let the user read provisioning with the new action
* let new action use decrypt flag
* add action and role to docs
2023-08-08 19:29:34 +03:00
faust e1d239a86e Docs: make it clear that MariaDB is also supported as datasource (#71832)
* Make it clear that MariaDB is also supported as datasource

MariaDB is now the default relational DB on lots of Linux distribution,
it's important to make it clear that it is perfectly supported.

* Fix 404 and make MySQL docs URL more robust

And lint with prettier.

* Review from lwandz13
2023-08-08 07:31:20 -06:00
Jean-Philippe Quéméner 2c6cf66741 Alerting: Optimize external Loki queries (#73014) 2023-08-08 15:13:41 +02:00
Ludovic Viaud 8d79d45972 Transformations: Fix partitionByValues when there is no match (#72981) 2023-08-08 15:10:31 +02:00
ismail simsek 1ac9e7eaab InfluxDB: Fix handling flux response with no time and value column (#72833)
* Upgrade the influxdb-client-go version

* Handle flux response with no time and value column
2023-08-08 15:00:52 +02:00
Sven Grossmann 533fae4c60 Logs: Fix displaying the wrong field as body (#73025)
* fix displaying the wrong field as body

* fix test

* fix `getFirstFieldOfType` with non-present type
2023-08-08 12:02:30 +02:00
Yulia Shanyrova 3c4d2edb61 Docs: Update screenshots for generating an access token for signing a plugin (#73031)
updated screenshots path and name
2023-08-08 11:26:39 +02:00
Sven Grossmann 703f4be15d Loki: Fix wrong context being passed to HTTP client (#72991)
use new context containing tracing information
2023-08-08 10:24:07 +02:00
Jack Westbrook 2d13af04c6 Chore: Bump semver npm package to latest (#72983)
build(npm): bump semver
2023-08-08 09:58:02 +02:00
Giuseppe Guerra ca8e9d4aab Chore: Bump github.com/grafana/grafana-plugin-sdk-go to v0.172.0 (#72989)
* Bump github.com/grafana/grafana-plugin-sdk-go

* go mod tidy

* go mod: added missing owners
2023-08-08 09:44:04 +02:00
mikkancso 1646b901af EditDatasource: Fix navtree when dataSourcePageHeader is on (#72827)
use useDataSourceSettingsNav from connections in DataSourceTabPage
2023-08-08 07:53:32 +02:00
54f0de313f docs: add default value workaround (#72545)
* Update _index.md

Fixes #https://github.com/grafana/support-escalations/issues/6376

Variables : Added Default values

* Update docs/sources/dashboards/variables/_index.md

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Ran prettier to resolve build errors

---------

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel Matwawana <isabel.matwawana@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2023-08-07 12:39:32 -04:00
Uri Okrent 27a8328d3a Plugins: opentsdb ds: interpolate filter variables in expressions (#71232)
Use the same code path to interpolate both metric variables and
filter/tag variables when the data source is accessed either directly or
via the expressions datasource.

partial fix for #48141 (opentsdb datasource only)

Signed-off-by: Uri Okrent <uokrent@gmail.com>
2023-08-07 18:05:13 +02:00
Gilles De MeyandGiordano Ricci ddc3784213 Alerting: Fix "see graph button" for cloud rules (#72980)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-08-07 17:19:29 +02:00
Matias Chomicki 869d3fc8b1 LogRowMessage: remove hardcoded true from condition (#72976) 2023-08-07 17:41:03 +03:00
Yulia Shanyrova ba3cbbef7f sign-plugin-docs: information of usage of a new token has been added to the docs (#72912)
* Documentation for signing a plugin has been updated

* changes after review

* small review change
2023-08-07 07:10:29 -07:00
ismail simsek 29906847e1 Prometheus: Fix fetching label values when datasource has no labels match api support (#72960)
* interpolate match string

* provide unit test

* add the third parameter back to fix the unit test
2023-08-07 15:13:08 +02:00
Sarah Zinger 6ac3348021 Datasource Plugins: Allow tracking for configuration usage (#72650)
Datasource Plugins: Allow tracking for configuration usage
2023-08-07 08:31:13 -04:00
Ludovic Viaud 867162b64a Transformation: keep collapsed states (#72601)
* Transformation: keep collapsed states

* Update
2023-08-07 14:20:12 +02:00
Fabrizio 6b8580ca8d Fix typos in contributing documentation (#72719) 2023-08-07 12:41:50 +03:00
Ashley Harrison 0ffdcbbe52 Chore: improve typings (#72679)
improve typings
2023-08-07 09:32:13 +01:00
Maksym RevutskyiandKarl Persson d9c232b331 Auth: prevent auto_login redirect if user is already authenticated (#72477)
* Auth: prevent auto_login redirect if user is already authenticated

Before attempting an auto-login for OAuth, verifies if current context has already been
authenticated.

Fixes: #72476

Co-authored-by: Karl Persson <kalle.persson92@gmail.com>
2023-08-07 09:14:31 +02:00
Sarah Zinger deeb1d85f8 Config: making [aws][external_id] part of env (#72062)
* Config: making [aws][external_id] part of env

* Fix go.sum

* Add a test
2023-08-04 16:06:01 -04:00
Sarah ZingerandFiona Artiaga 306e7bfa89 Documentation: Clarify how to use prometheus locally (#72846)
Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>
2023-08-04 15:00:05 -04:00
Yuri TseretyanandMatthew Jacobson 0053b07885 Alerting: Refactor of state manager tests (#72849)
* calculate cacheID instead of literals
   * use mocked clocks
   * advance clocks with the eval results
   * use clearer timestamp aliases
   * make expected state labels be more clear to read
Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>
2023-08-04 13:39:49 -04:00
Nathan Marrs 9328febbab Trend: Fix x field matching logic (#72862) 2023-08-04 10:12:51 -07:00
Drew Slobodnjak 92e7829e7a Geomap: Fix fixed edge text for network layer (#72863)
Geomap: Fix fixed edge text
2023-08-04 08:21:13 -07:00
ismail simsek c344b0e427 Chore: Use the const instead of hardcoded string (#72925)
* Use the const instead of hardcoded string

* Use the const instead of hardcoded string

* Fix unit test
2023-08-04 16:55:33 +02:00
Konrad Lalik 4b73e96d93 Alerting: Fix cloud rules editing (#72927) 2023-08-04 16:46:58 +02:00
linoman 01721d910e Auth: Add documentation references to No Basic role (#72880)
* Update the documentation

* Add references to the documentation

* Replace X with YES in roles table
2023-08-04 16:29:24 +02:00
Eric LeijonmarckandChristopher Moyer 95760cb021 Auth: OAuth sets skip_org_role_sync = true for auth.google by default (#72819)
* sets skip_org_role_sync to true for google

* add google skiporgrolesync and sets to true always

* add field

* Update docs/sources/setup-grafana/configure-security/configure-authentication/google/index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* add AKS to words

* script back to mina

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-08-04 16:17:35 +02:00
ismail simsek 3395ad03a7 InfluxDB: Fix retention policy handling for InfluxDB 3.0 engine by bringing back the hardcoded default (#72467)
* Revert retention policy handling

* Remove comment

* Send retention policy with request when it's possible
2023-08-04 15:57:41 +02:00
David Allen 0d6e911fff Update bind-net-capabilities.md (#65181)
This doc fragment is included on multiple pages including this one: https://grafana.com/docs/grafana/latest/setup-grafana/installation/debian/

the only flaw is it's missing "sudo".  Modern linux practice suggests using sudo for all administrative edits like this, and this change reinforces parallel structure in the target docs page.  There may potentially be some other context this fragment is used in where sudo isn't appropriate, but this makes it easier to copy/paste the command and have it work on modern linuxes.
2023-08-04 06:37:13 -07:00
Kristin Laemmert 2569081165 chore: minor refactoring in the grafana server cli command (#72847)
This is preparative work for extending the grafana server cli command to target individual dskit modules that seemed worth breaking into this smaller PR. This moves the CLI flags and various reusable chunks of code into variables and methods.
2023-08-04 08:03:47 -04:00
Will Browne 98f827537b Plugins: Add remaining steps to inititialization stage (#72894)
add remainder of init steps
2023-08-04 12:35:57 +02:00
Will BrowneandGiuseppe Guerra 60b4a0b2a4 Plugins: Add termination stage to plugin loader pipeline (#72822)
* add termination stage

* uid -> pluginID (for now)

* also fix fakes

* add simple test

* Fix logger name

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>

* inline stop func call

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>

---------

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
2023-08-04 11:57:49 +02:00