Update .github/CODEOWNERS

Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>
revert
2025-12-15 09:23:10 +01:00 · 2025-12-12 17:51:18 +01:00 · 2025-12-12 17:50:22 +01:00 · 2025-12-12 17:48:59 +01:00 · 2025-12-12 17:48:13 +01:00 · 2025-12-12 17:26:29 +01:00
10 changed files with 401 additions and 138 deletions
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -77,11 +77,11 @@
 /.air.toml @macabu

 # Git Sync / App Platform Provisioning
-/apps/provisioning/ @grafana/grafana-git-ui-sync-team
-/pkg/operators @grafana/grafana-git-ui-sync-team
-/public/app/features/provisioning @grafana/grafana-git-ui-sync-team
-/pkg/registry/apis/provisioning @grafana/grafana-git-ui-sync-team
-/pkg/tests/apis/provisioning @grafana/grafana-git-ui-sync-team
+/apps/provisioning/ @grafana/grafana-app-platform-squad
+/pkg/operators @grafana/grafana-app-platform-squad
+/public/app/features/provisioning @grafana/grafana-search-navigate-organise
+/pkg/registry/apis/provisioning @grafana/grafana-app-platform-squad
+/pkg/tests/apis/provisioning @grafana/grafana-app-platform-squad
 # Git Sync frontend owned by frontend team as a whole.

 /apps/alerting/ @grafana/alerting-backend
@@ -753,7 +753,7 @@ i18next.config.ts @grafana/grafana-frontend-platform
 /packages/grafana-api-clients/src/clients/rtkq/iam/ @grafana/access-squad @grafana/identity-squad
 /packages/grafana-api-clients/src/clients/rtkq/logsdrilldown/ @grafana/observability-logs
 /packages/grafana-api-clients/src/clients/rtkq/preferences/ @grafana/plugins-platform-frontend
-/packages/grafana-api-clients/src/clients/rtkq/provisioning/ @grafana/grafana-git-ui-sync-team
+/packages/grafana-api-clients/src/clients/rtkq/provisioning/ @grafana/grafana-search-navigate-organise
 /packages/grafana-api-clients/src/clients/rtkq/shorturl/ @grafana/sharing-squad

 # root files, mostly frontend
@@ -1084,7 +1084,7 @@ playwright.storybook.config.ts @grafana/grafana-frontend-platform
 eslint-suppressions.json @grafanabot

 # Design system
-/public/img/icons/unicons/ @grafana/design-system
+/public/img/icons/unicons/ @grafana/product-design-engineering

 # Core datasources
 /public/app/plugins/datasource/dashboard/ @grafana/dashboards-squad
@@ -1260,11 +1260,11 @@ embed.go @grafana/grafana-as-code
 /.github/workflows/stale.yml @grafana/grafana-developer-enablement-squad
 /.github/workflows/storybook-a11y.yml @grafana/grafana-frontend-platform
 /.github/workflows/update-make-docs.yml @grafana/docs-tooling
-/.github/workflows/scripts/kinds/verify-kinds.go @grafana/platform-monitoring
+/.github/workflows/scripts/kinds/verify-kinds.go @grafana/grafana-app-platform-squad
 /.github/workflows/scripts/create-security-branch/create-security-branch.sh @grafana/grafana-developer-enablement-squad
-/.github/workflows/publish-kinds-next.yml @grafana/platform-monitoring
-/.github/workflows/publish-kinds-release.yml @grafana/platform-monitoring
-/.github/workflows/verify-kinds.yml @grafana/platform-monitoring
+/.github/workflows/publish-kinds-next.yml @grafana/grafana-app-platform-squad
+/.github/workflows/publish-kinds-release.yml @grafana/grafana-app-platform-squad
+/.github/workflows/verify-kinds.yml @grafana/grafana-app-platform-squad
 /.github/workflows/dashboards-issue-add-label.yml @grafana/dashboards-squad
 /.github/workflows/run-schema-v2-e2e.yml  @grafana/dashboards-squad
 /.github/workflows/run-dashboard-search-e2e.yml  @grafana/grafana-search-and-storage
@@ -1325,7 +1325,7 @@ embed.go @grafana/grafana-as-code
 /conf/provisioning/dashboards/ @grafana/dashboards-squad
 /conf/provisioning/datasources/ @grafana/plugins-platform-backend
 /conf/provisioning/plugins/ @grafana/plugins-platform-backend
-/conf/provisioning/sample/ @grafana/grafana-git-ui-sync-team
+/conf/provisioning/sample/ @grafana/grafana-app-platform-squad

 # Security
 /relyance.yaml @grafana/security-team
--- a/apps/dashboard/pkg/migration/testdata/dev-dashboards-output/panel-gauge/gauge_tests_new.v42.json
+++ b/apps/dashboard/pkg/migration/testdata/dev-dashboards-output/panel-gauge/gauge_tests_new.v42.json
@@ -1603,7 +1603,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1671,7 +1670,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 98,
          "min": 5,
          "noise": 22,
@@ -1689,7 +1687,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1757,7 +1754,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 98,
          "min": 5,
          "noise": 22,
@@ -1788,7 +1784,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1857,7 +1852,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 8,
          "min": 1,
          "noise": 2,
@@ -1875,7 +1869,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1944,7 +1937,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 12,
          "min": 1,
          "noise": 2,
@@ -1962,7 +1954,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -2030,7 +2021,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 100,
          "min": 10,
          "noise": 22,
@@ -2048,7 +2038,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -2116,7 +2105,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 100,
          "min": 10,
          "noise": 22,
@@ -2129,6 +2117,147 @@
      ],
      "title": "Backend",
      "type": "radialbar"
+    },
+    {
+      "collapsed": false,
+      "gridPos": {
+        "h": 1,
+        "w": 24,
+        "x": 0,
+        "y": 66
+      },
+      "id": 35,
+      "panels": [],
+      "title": "Empty data",
+      "type": "row"
+    },
+    {
+      "datasource": {
+        "type": "grafana-testdata-datasource"
+      },
+      "fieldConfig": {
+        "defaults": {
+          "mappings": [],
+          "thresholds": {
+            "mode": "absolute",
+            "steps": [
+              {
+                "color": "green",
+                "value": 0
+              },
+              {
+                "color": "red",
+                "value": 80
+              }
+            ]
+          }
+        },
+        "overrides": []
+      },
+      "gridPos": {
+        "h": 8,
+        "w": 6,
+        "x": 0,
+        "y": 67
+      },
+      "id": 36,
+      "options": {
+        "barWidthFactor": 0.5,
+        "effects": {
+          "barGlow": false,
+          "centerGlow": false,
+          "gradient": true,
+          "rounded": false,
+          "spotlight": false
+        },
+        "orientation": "auto",
+        "reduceOptions": {
+          "calcs": ["lastNotNull"],
+          "fields": "",
+          "values": false
+        },
+        "segmentCount": 1,
+        "segmentSpacing": 0.3,
+        "shape": "gauge",
+        "showThresholdLabels": false,
+        "showThresholdMarkers": true,
+        "sparkline": true
+      },
+      "pluginVersion": "13.0.0-pre",
+      "targets": [
+        {
+          "refId": "A",
+          "scenarioId": "random_walk",
+          "seriesCount": 0
+        }
+      ],
+      "title": "Numeric, no series",
+      "type": "gauge"
+    },
+    {
+      "datasource": {
+        "type": "grafana-testdata-datasource"
+      },
+      "fieldConfig": {
+        "defaults": {
+          "color": {
+            "mode": "thresholds"
+          },
+          "mappings": [],
+          "thresholds": {
+            "mode": "absolute",
+            "steps": [
+              {
+                "color": "green",
+                "value": 0
+              },
+              {
+                "color": "red",
+                "value": 80
+              }
+            ]
+          }
+        },
+        "overrides": []
+      },
+      "gridPos": {
+        "h": 8,
+        "w": 6,
+        "x": 6,
+        "y": 67
+      },
+      "id": 37,
+      "options": {
+        "barWidthFactor": 0.5,
+        "effects": {
+          "barGlow": false,
+          "centerGlow": false,
+          "gradient": true,
+          "rounded": false,
+          "spotlight": false
+        },
+        "orientation": "auto",
+        "reduceOptions": {
+          "calcs": ["lastNotNull"],
+          "fields": "",
+          "values": false
+        },
+        "segmentCount": 1,
+        "segmentSpacing": 0.3,
+        "shape": "gauge",
+        "showThresholdLabels": false,
+        "showThresholdMarkers": true,
+        "sparkline": true
+      },
+      "pluginVersion": "13.0.0-pre",
+      "targets": [
+        {
+          "refId": "A",
+          "scenarioId": "logs"
+        }
+      ],
+      "title": "Non-numeric",
+      "type": "gauge"
    }
  ],
  "preload": false,
--- a/devenv/dev-dashboards/panel-gauge/gauge_tests_new.json
+++ b/devenv/dev-dashboards/panel-gauge/gauge_tests_new.json
@@ -75,9 +75,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": false,
          "rounded": true,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -152,9 +152,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -229,9 +229,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -306,9 +306,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -383,9 +383,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -460,9 +460,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": false,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -537,9 +537,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": false,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -627,9 +627,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -704,9 +704,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -781,9 +781,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -858,9 +858,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": false,
          "rounded": true,
-          "spotlight": true,
-          "gradient": false
+          "spotlight": true
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -952,9 +952,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": false,
          "rounded": false,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1029,9 +1029,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": false,
          "rounded": false,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1106,9 +1106,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": true,
          "rounded": false,
-          "spotlight": false,
-          "gradient": true
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1183,9 +1183,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": false,
          "rounded": false,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1260,9 +1260,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": false,
          "rounded": false,
-          "spotlight": false,
-          "gradient": false
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1354,9 +1354,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": true,
          "rounded": false,
-          "spotlight": false,
-          "gradient": true
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1435,9 +1435,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": true,
          "rounded": false,
-          "spotlight": false,
-          "gradient": true
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1516,9 +1516,9 @@
        "effects": {
          "barGlow": false,
          "centerGlow": false,
+          "gradient": true,
          "rounded": false,
-          "spotlight": false,
-          "gradient": true
+          "spotlight": false
        },
        "orientation": "auto",
        "reduceOptions": {
@@ -1565,7 +1565,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1606,9 +1605,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": true,
          "rounded": true,
-          "spotlight": true,
-          "gradient": true
+          "spotlight": true
        },
        "glow": "both",
        "orientation": "auto",
@@ -1631,7 +1630,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 98,
          "min": 5,
          "noise": 22,
@@ -1649,7 +1647,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1690,9 +1687,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": true,
          "rounded": true,
-          "spotlight": true,
-          "gradient": true
+          "spotlight": true
        },
        "glow": "both",
        "orientation": "auto",
@@ -1715,7 +1712,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 98,
          "min": 5,
          "noise": 22,
@@ -1746,7 +1742,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1788,9 +1783,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": true,
          "rounded": true,
-          "spotlight": true,
-          "gradient": true
+          "spotlight": true
        },
        "glow": "both",
        "orientation": "auto",
@@ -1813,7 +1808,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 8,
          "min": 1,
          "noise": 2,
@@ -1831,7 +1825,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1873,9 +1866,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": true,
          "rounded": true,
-          "spotlight": true,
-          "gradient": true
+          "spotlight": true
        },
        "glow": "both",
        "orientation": "auto",
@@ -1898,7 +1891,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 12,
          "min": 1,
          "noise": 2,
@@ -1916,7 +1908,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -1957,9 +1948,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": true,
          "rounded": true,
-          "spotlight": true,
-          "gradient": true
+          "spotlight": true
        },
        "glow": "both",
        "orientation": "auto",
@@ -1982,7 +1973,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 100,
          "min": 10,
          "noise": 22,
@@ -2000,7 +1990,6 @@
      "datasource": {
        "type": "grafana-testdata-datasource"
      },
-      "description": "",
      "fieldConfig": {
        "defaults": {
          "color": {
@@ -2041,9 +2030,9 @@
        "effects": {
          "barGlow": true,
          "centerGlow": true,
+          "gradient": true,
          "rounded": true,
-          "spotlight": true,
-          "gradient": true
+          "spotlight": true
        },
        "glow": "both",
        "orientation": "auto",
@@ -2066,7 +2055,6 @@
          "datasource": {
            "type": "grafana-testdata-datasource"
          },
-          "hide": false,
          "max": 100,
          "min": 10,
          "noise": 22,
@@ -2079,6 +2067,147 @@
      ],
      "title": "Backend",
      "type": "radialbar"
+    },
+    {
+      "collapsed": false,
+      "gridPos": {
+        "h": 1,
+        "w": 24,
+        "x": 0,
+        "y": 66
+      },
+      "id": 35,
+      "panels": [],
+      "title": "Empty data",
+      "type": "row"
+    },
+    {
+      "datasource": {
+        "type": "grafana-testdata-datasource"
+      },
+      "fieldConfig": {
+        "defaults": {
+          "mappings": [],
+          "thresholds": {
+            "mode": "absolute",
+            "steps": [
+              {
+                "color": "green",
+                "value": 0
+              },
+              {
+                "color": "red",
+                "value": 80
+              }
+            ]
+          }
+        },
+        "overrides": []
+      },
+      "gridPos": {
+        "h": 8,
+        "w": 6,
+        "x": 0,
+        "y": 67
+      },
+      "id": 36,
+      "options": {
+        "barWidthFactor": 0.5,
+        "effects": {
+          "barGlow": false,
+          "centerGlow": false,
+          "gradient": true,
+          "rounded": false,
+          "spotlight": false
+        },
+        "orientation": "auto",
+        "reduceOptions": {
+          "calcs": ["lastNotNull"],
+          "fields": "",
+          "values": false
+        },
+        "segmentCount": 1,
+        "segmentSpacing": 0.3,
+        "shape": "gauge",
+        "showThresholdLabels": false,
+        "showThresholdMarkers": true,
+        "sparkline": true
+      },
+      "pluginVersion": "13.0.0-pre",
+      "targets": [
+        {
+          "refId": "A",
+          "scenarioId": "random_walk",
+          "seriesCount": 0
+        }
+      ],
+      "title": "Numeric, no series",
+      "type": "gauge"
+    },
+    {
+      "datasource": {
+        "type": "grafana-testdata-datasource"
+      },
+      "fieldConfig": {
+        "defaults": {
+          "color": {
+            "mode": "thresholds"
+          },
+          "mappings": [],
+          "thresholds": {
+            "mode": "absolute",
+            "steps": [
+              {
+                "color": "green",
+                "value": 0
+              },
+              {
+                "color": "red",
+                "value": 80
+              }
+            ]
+          }
+        },
+        "overrides": []
+      },
+      "gridPos": {
+        "h": 8,
+        "w": 6,
+        "x": 6,
+        "y": 67
+      },
+      "id": 37,
+      "options": {
+        "barWidthFactor": 0.5,
+        "effects": {
+          "barGlow": false,
+          "centerGlow": false,
+          "gradient": true,
+          "rounded": false,
+          "spotlight": false
+        },
+        "orientation": "auto",
+        "reduceOptions": {
+          "calcs": ["lastNotNull"],
+          "fields": "",
+          "values": false
+        },
+        "segmentCount": 1,
+        "segmentSpacing": 0.3,
+        "shape": "gauge",
+        "showThresholdLabels": false,
+        "showThresholdMarkers": true,
+        "sparkline": true
+      },
+      "pluginVersion": "13.0.0-pre",
+      "targets": [
+        {
+          "refId": "A",
+          "scenarioId": "logs"
+        }
+      ],
+      "title": "Non-numeric",
+      "type": "gauge"
    }
  ],
  "preload": false,
@@ -2095,5 +2224,5 @@
  "timezone": "browser",
  "title": "Panel tests - Gauge (new)",
  "uid": "panel-tests-gauge-new",
-  "version": 6
+  "version": 9
 }
--- a/packages/grafana-ui/src/components/RadialGauge/RadialGauge.tsx
+++ b/packages/grafana-ui/src/components/RadialGauge/RadialGauge.tsx
@@ -106,6 +106,11 @@ export function RadialGauge(props: RadialGaugeProps) {
  const gaugeId = useId();
  const styles = useStyles2(getStyles);

+  let effectiveTextMode = textMode;
+  if (effectiveTextMode === 'auto') {
+    effectiveTextMode = vizCount === 1 ? 'value' : 'value_and_name';
+  }
+
  const startAngle = shape === 'gauge' ? 250 : 0;
  const endAngle = shape === 'gauge' ? 110 : 360;

@@ -188,7 +193,7 @@ export function RadialGauge(props: RadialGaugeProps) {
    // These elements are only added for first value / bar
    if (barIndex === 0) {
      if (glowBar) {
-        defs.push(<GlowGradient key="glow-filter" id={glowFilterId} radius={dimensions.radius} />);
+        defs.push(<GlowGradient key="glow-filter" id={glowFilterId} barWidth={dimensions.barWidth} />);
      }

      if (glowCenter) {
@@ -198,14 +203,14 @@ export function RadialGauge(props: RadialGaugeProps) {
      graphics.push(
        <RadialText
          key="radial-text"
-          vizCount={vizCount}
-          textMode={textMode}
+          textMode={effectiveTextMode}
          displayValue={displayValue.display}
          dimensions={dimensions}
          theme={theme}
          valueManualFontSize={props.valueManualFontSize}
          nameManualFontSize={props.nameManualFontSize}
          shape={shape}
+          sparkline={displayValue.sparkline}
        />
      );

@@ -254,6 +259,7 @@ export function RadialGauge(props: RadialGaugeProps) {
            theme={theme}
            color={color}
            shape={shape}
+            textMode={effectiveTextMode}
          />
        );
      }
--- a/packages/grafana-ui/src/components/RadialGauge/RadialSparkline.tsx
+++ b/packages/grafana-ui/src/components/RadialGauge/RadialSparkline.tsx
@@ -1,11 +1,9 @@
-import { css } from '@emotion/css';
-
 import { FieldDisplay, GrafanaTheme2, FieldConfig } from '@grafana/data';
 import { GraphFieldConfig, GraphGradientMode, LineInterpolation } from '@grafana/schema';

 import { Sparkline } from '../Sparkline/Sparkline';

-import { RadialShape } from './RadialGauge';
+import { RadialShape, RadialTextMode } from './RadialGauge';
 import { GaugeDimensions } from './utils';

 interface RadialSparklineProps {
@@ -14,23 +12,22 @@ interface RadialSparklineProps {
  theme: GrafanaTheme2;
  color?: string;
  shape?: RadialShape;
+  textMode: Exclude<RadialTextMode, 'auto'>;
 }
-export function RadialSparkline({ sparkline, dimensions, theme, color, shape }: RadialSparklineProps) {
+export function RadialSparkline({ sparkline, dimensions, theme, color, shape, textMode }: RadialSparklineProps) {
+  const { radius, barWidth } = dimensions;
+
  if (!sparkline) {
    return null;
  }

-  const { radius, barWidth } = dimensions;
-
-  const height = radius / 4;
-  const widthFactor = shape === 'gauge' ? 1.6 : 1.4;
-  const width = radius * widthFactor - barWidth;
-  const topPos = shape === 'gauge' ? `${dimensions.gaugeBottomY - height}px` : `calc(50% + ${radius / 2.8}px)`;
-
-  const styles = css({
-    position: 'absolute',
-    top: topPos,
-  });
+  const showNameAndValue = textMode === 'value_and_name';
+  const height = radius / (showNameAndValue ? 4 : 3);
+  const width = radius * (shape === 'gauge' ? 1.6 : 1.4) - barWidth;
+  const topPos =
+    shape === 'gauge'
+      ? `${dimensions.gaugeBottomY - height}px`
+      : `calc(50% + ${radius / (showNameAndValue ? 3.3 : 4)}px)`;

  const config: FieldConfig<GraphFieldConfig> = {
    color: {
@@ -45,7 +42,7 @@ export function RadialSparkline({ sparkline, dimensions, theme, color, shape }:
  };

  return (
-    <div className={styles}>
+    <div style={{ position: 'absolute', top: topPos }}>
      <Sparkline height={height} width={width} sparkline={sparkline} theme={theme} config={config} />
    </div>
  );
--- a/packages/grafana-ui/src/components/RadialGauge/RadialText.tsx
+++ b/packages/grafana-ui/src/components/RadialGauge/RadialText.tsx
@@ -1,6 +1,12 @@
 import { css } from '@emotion/css';

-import { DisplayValue, DisplayValueAlignmentFactors, formattedValueToString, GrafanaTheme2 } from '@grafana/data';
+import {
+  DisplayValue,
+  DisplayValueAlignmentFactors,
+  FieldSparkline,
+  formattedValueToString,
+  GrafanaTheme2,
+} from '@grafana/data';

 import { useStyles2 } from '../../themes/ThemeContext';
 import { calculateFontSize } from '../../utils/measureText';
@@ -8,21 +14,13 @@ import { calculateFontSize } from '../../utils/measureText';
 import { RadialShape, RadialTextMode } from './RadialGauge';
 import { GaugeDimensions } from './utils';

-// function toCartesian(centerX: number, centerY: number, radius: number, angleInDegrees: number) {
-//   let radian = ((angleInDegrees - 90) * Math.PI) / 180.0;
-//   return {
-//     x: centerX + radius * Math.cos(radian),
-//     y: centerY + radius * Math.sin(radian),
-//   };
-// }
-
 interface RadialTextProps {
  displayValue: DisplayValue;
  theme: GrafanaTheme2;
  dimensions: GaugeDimensions;
-  textMode: RadialTextMode;
-  vizCount: number;
+  textMode: Exclude<RadialTextMode, 'auto'>;
  shape: RadialShape;
+  sparkline?: FieldSparkline;
  alignmentFactors?: DisplayValueAlignmentFactors;
  valueManualFontSize?: number;
  nameManualFontSize?: number;
@@ -33,8 +31,8 @@ export function RadialText({
  theme,
  dimensions,
  textMode,
-  vizCount,
  shape,
+  sparkline,
  alignmentFactors,
  valueManualFontSize,
  nameManualFontSize,
@@ -46,10 +44,6 @@ export function RadialText({
    return null;
  }

-  if (textMode === 'auto') {
-    textMode = vizCount === 1 ? 'value' : 'value_and_name';
-  }
-
  const nameToAlignTo = (alignmentFactors ? alignmentFactors.title : displayValue.title) ?? '';
  const valueToAlignTo = formattedValueToString(alignmentFactors ? alignmentFactors : displayValue);

@@ -59,7 +53,7 @@ export function RadialText({

  // Not sure where this comes from but svg text is not using body line-height
  const lineHeight = 1.21;
-  const valueWidthToRadiusFactor = 0.85;
+  const valueWidthToRadiusFactor = 0.82;
  const nameToHeightFactor = 0.45;
  const largeRadiusScalingDecay = 0.86;

@@ -98,18 +92,23 @@ export function RadialText({
  const valueHeight = valueFontSize * lineHeight;
  const nameHeight = nameFontSize * lineHeight;

-  const valueY = showName ? centerY - nameHeight / 2 : centerY;
-  const valueNameSpacing = valueHeight / 3.5;
-  const nameY = showValue ? valueY + valueHeight / 2 + valueNameSpacing : centerY;
+  const valueY = showName ? centerY - nameHeight * 0.3 : centerY;
+  const nameY = showValue ? valueY + valueHeight * 0.7 : centerY;
  const nameColor = showValue ? theme.colors.text.secondary : theme.colors.text.primary;
  const suffixShift = (valueFontSize - unitFontSize * 1.2) / 2;

-  // For gauge shape we shift text up a bit
-  const valueDy = shape === 'gauge' ? -valueFontSize * 0.3 : 0;
-  const nameDy = shape === 'gauge' ? -nameFontSize * 0.7 : 0;
+  // adjust the text up on gauges and when sparklines are present
+  let yOffset = 0;
+  if (shape === 'gauge') {
+    // we render from the center of the gauge, so move up by half of half of the total height
+    yOffset -= (valueHeight + nameHeight) / 4;
+  }
+  if (sparkline) {
+    yOffset -= 8;
+  }

  return (
-    <g>
+    <g transform={`translate(0, ${yOffset})`}>
      {showValue && (
        <text
          x={centerX}
@@ -119,7 +118,6 @@ export function RadialText({
          className={styles.text}
          textAnchor="middle"
          dominantBaseline="middle"
-          dy={valueDy}
        >
          <tspan fontSize={unitFontSize}>{displayValue.prefix ?? ''}</tspan>
          <tspan>{displayValue.text}</tspan>
@@ -133,7 +131,6 @@ export function RadialText({
          fontSize={nameFontSize}
          x={centerX}
          y={nameY}
-          dy={nameDy}
          textAnchor="middle"
          dominantBaseline="middle"
          fill={nameColor}
--- a/packages/grafana-ui/src/components/RadialGauge/effects.tsx
+++ b/packages/grafana-ui/src/components/RadialGauge/effects.tsx
@@ -4,11 +4,12 @@ import { GaugeDimensions } from './utils';

 export interface GlowGradientProps {
  id: string;
-  radius: number;
+  barWidth: number;
 }

-export function GlowGradient({ id, radius }: GlowGradientProps) {
-  const glowSize = 0.02 * radius;
+export function GlowGradient({ id, barWidth }: GlowGradientProps) {
+  // 0.75 is the minimum glow size, and it scales with bar width
+  const glowSize = 0.75 + barWidth * 0.08;

  return (
    <filter id={id} filterUnits="userSpaceOnUse">
@@ -82,7 +83,7 @@ export function MiddleCircleGlow({ dimensions, gaugeId, color }: CenterGlowProps
    <>
      <defs>
        <radialGradient id={gradientId} r={'50%'} fr={'0%'}>
-          <stop offset="0%" stopColor={color} stopOpacity={0.2} />
+          <stop offset="0%" stopColor={color} stopOpacity={0.15} />
          <stop offset="90%" stopColor={color} stopOpacity={0} />
        </radialGradient>
      </defs>
--- a/public/app/features/explore/Logs/Logs.tsx
+++ b/public/app/features/explore/Logs/Logs.tsx
@@ -789,7 +789,6 @@ const UnthemedLogs: React.FunctionComponent<Props> = (props: Props) => {
          logOptionsStorageKey={SETTING_KEY_ROOT}
          timeZone={timeZone}
          displayedFields={displayedFields}
-          onPermalinkClick={onPermalinkClick}
          onClickShowField={showField}
          onClickHideField={hideField}
        />
--- a/public/app/plugins/panel/logs/LogsPanel.tsx
+++ b/public/app/plugins/panel/logs/LogsPanel.tsx
@@ -566,7 +566,6 @@ export const LogsPanel = ({
          logLineMenuCustomItems={isLogLineMenuCustomItems(logLineMenuCustomItems) ? logLineMenuCustomItems : undefined}
          timeZone={timeZone}
          displayedFields={displayedFields}
-          onPermalinkClick={showPermaLink() ? onPermalinkClick : undefined}
          onClickShowField={showField}
          onClickHideField={hideField}
        />
--- a/public/app/plugins/panel/radialbar/RadialBarPanel.tsx
+++ b/public/app/plugins/panel/radialbar/RadialBarPanel.tsx
@@ -7,6 +7,7 @@ import {
  getFieldDisplayValues,
  PanelProps,
 } from '@grafana/data';
+import { PanelDataErrorView } from '@grafana/runtime';
 import { DataLinksContextMenu, Stack, VizRepeater, VizRepeaterRenderValueProps } from '@grafana/ui';
 import { DataLinksContextMenuApi, RadialGauge } from '@grafana/ui/internal';
 import { config } from 'app/core/config';
@@ -14,6 +15,7 @@ import { config } from 'app/core/config';
 import { Options } from './panelcfg.gen';

 export function RadialBarPanel({
+  id,
  height,
  width,
  data,
@@ -88,6 +90,10 @@ export function RadialBarPanel({
  const minVizHeight = 60;
  const minVizWidth = 60;

+  if (getValues()[0]?.display?.text === 'No data') {
+    return <PanelDataErrorView panelId={id} fieldConfig={fieldConfig} data={data} needsNumberField />;
+  }
+
  return (
    <Stack direction="row" justifyContent="center" alignItems="center" height={'100%'}>
      <VizRepeater
Author	SHA1	Message	Date
Timur Olzhabayev	8e781a5577	Update .github/CODEOWNERS Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>	2025-12-15 09:23:10 +01:00
Timur Olzhabayev	d2d3f02db8	revert	2025-12-12 17:51:18 +01:00
Timur Olzhabayev	2947db067c	replace platform-monitoring	2025-12-12 17:50:22 +01:00
Timur Olzhabayev	b903ef8a65	changing unicorns ownership	2025-12-12 17:48:59 +01:00
Timur Olzhabayev	86c3da53d6	fixing codeowners	2025-12-12 17:48:13 +01:00
Timur Olzhabayev	1573e0cc40	Avoid context resuse when logging an error	2025-12-12 17:26:29 +01:00
Matias Chomicki	f35447435f	LogLineContext: remove broken permalink prop (#115252 )	2025-12-12 16:24:36 +00:00
Paul Marbach	c0dc92e8cd	Gauge: Fit-and-finish tweaks to glows, text position, and sparkline size (#115173 ) * Gauge: Fit-and-finish tweaks to glows, text position, and sparkline size * adjust text height and positions a little more * cohesive no data handling * more tweaks * fix migration test * Fix JSON formatting by adding missing newline * remove new line	2025-12-12 11:10:56 -05:00