addressed comments

This commit is contained in:
Denise Schannon
2018-06-21 15:38:15 -07:00
parent 6c5d061aee
commit 4243a82b84
3 changed files with 3 additions and 3 deletions
@@ -10,7 +10,7 @@ There are several options that can be configured in cluster configuration option
### Configuring Nodes
* [Nodes]({{< baseurl >}}/rke/v0.1.x/en/config-options/nodes/)
* [Ignoring supported Docker versions](#supported-docker-versions)
* [Ignoring unsupported Docker versions](#supported-docker-versions)
* [Private Registries]({{< baseurl >}}/rke/v0.1.x/en/config-options/private-registries/)
* [Cluster Level SSH Key Path](#cluster-level-ssh-key-path)
* [SSH Agent](#ssh-agent)
@@ -50,7 +50,7 @@ The `internal_address` provides the ability to have nodes with multiple addresse
The `hostname_override` is used to be able to provide a friendly name for RKE to use when registering the node in Kubernetes. This hostname doesn't need to be a routable address. If the `hostname_override` isn't set, then the `address` directive is used when registering the node in Kubernetes.
> **Note:** When [cloud providers]({{< baseurl >}}/rke/v0.1.x/en/config-options/cloud-providers/) are configured, you may need to override the hostname in order to use the cloud provider correctly.
> **Note:** When [cloud providers]({{< baseurl >}}/rke/v0.1.x/en/config-options/cloud-providers/) are configured, you may need to override the hostname in order to use the cloud provider correctly. There is an exception for the AWS cloud provider, where the `hostname_override` field will be explicitly ignored.
### SSH Port
@@ -8,7 +8,7 @@ RKE supports the ability to configure your Kubernetes components by adding in ex
## Extra Args
For the `kube-controller`, you can update the `extra_args` to change the existing defaults.
For any of the Kubernetes services, you can update the `extra_args` to change the existing defaults.
As of `v0.1.3`, using `extra_args` will add new arguments and **override** any existing defaults. For example, if you need to modify the default admission controllers list, you need to include the default list and edit it with your changes so all changes are included.