Apply suggestions from code review

Co-authored-by: Billy Tat <btat@suse.com>
This commit is contained in:
Lucas Saintarbor
2024-01-16 16:44:14 -08:00
committed by GitHub
co-authored by Billy Tat
parent b865f5095c
commit c2b95c9b26
3 changed files with 8 additions and 8 deletions
@@ -14,7 +14,7 @@ Your EKS cluster requires that you install an OIDC provider. To check that you'v
aws eks describe-cluster --name <cluster-name> --region <region> --query cluster.identity.oidc.issuer --output text
```
This should return an URL, such as `https://oidc.eks.region.amazonaws.com/id/1234567890ABCDEF`. The part after `https://` (e.g. `oidc.eks.region.amazonaws.com/id/1234567890ABCDEF`) is the OIDC Provider Identity. The final section of the URL, `1234567890ABCDEF`, is the OIDC ID.
This should return a URL, such as `https://oidc.eks.region.amazonaws.com/id/1234567890ABCDEF`. The part after `https://` (e.g. `oidc.eks.region.amazonaws.com/id/1234567890ABCDEF`) is the OIDC Provider Identity. The final section of the URL, `1234567890ABCDEF`, is the OIDC ID.
Use the OIDC ID to check if the EKS cluster has a provider:
@@ -155,6 +155,6 @@ Uninstalling Rancher Prime may not remove all of the Kubernetes resources create
The best practice for uninstalling the Rancher Prime PAYG offering is to migrate any non-Rancher workloads to a different cluster and destroy the Rancher cluster.
:::note warning
:::warning
Ensure you prepare and migrate any non-Rancher workloads off the cluster before destroying the cluster since these resources are not recoverable.
:::
@@ -8,7 +8,7 @@ Before using Rancher Prime on AWS as a pay-as-you-go (PAYG) offering, you need t
- An ingress on the EKS cluster, so that Rancher is accessible from outside the cluster. See the [Rancher documentation](../../../getting-started/installation-and-upgrade/install-upgrade-on-a-kubernetes-cluster/rancher-on-amazon-eks.md#5-install-an-ingress) for instructions on deploying Ingress-NGINX on an EKS cluster.
- The Load Balancer IP address. See the [Rancher documentation](../../../getting-started/installation-and-upgrade/install-upgrade-on-a-kubernetes-cluster/rancher-on-amazon-eks.md#6-get-load-balancer-ip) and save the `EXTERNAL-IP`.
- The Rancher hostname. The hostname must be a fully qualified domain name (FQDN), and its corresponding IP address must be resolvable from a public DNS. See the [Rancher documentation](../../../getting-started/installation-and-upgrade/install-upgrade-on-a-kubernetes-cluster/rancher-on-amazon-eks.md#7-set-up-dns) for instructions on how to set up DNS. This DNS points to the `EXTERNAL-IP`.
- [`aws`](https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html).
- [`curl`](https://curl.se/docs/install.html).
- [`eksctl`](https://eksctl.io/installation/).
- [`helm` (v3 or greater)](https://helm.sh/docs/intro/quickstart/#install-helm).
- [`aws`](https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html).
- [`curl`](https://curl.se/docs/install.html).
- [`eksctl`](https://eksctl.io/installation/).
- [`helm` (v3 or greater)](https://helm.sh/docs/intro/quickstart/#install-helm).
@@ -54,7 +54,7 @@ On the **Rancher Configuraion** tab, specify the following information:
:::
1. Select **Next**.
### Review + Create
### Review + create
1. On the **Review + create** tab, review the summary of the offer (Price, Basics, Rancher Configuration) and the link to **view automation template** (Azure Resource Manager Template).
1. Select **Create** to start the deployment.
@@ -99,6 +99,6 @@ Uninstalling Rancher Prime may not remove all of the Kubernetes resources create
The best practice for uninstalling the Rancher Prime PAYG offering is to migrate any non-Rancher workloads to a different cluster and destroy the Rancher cluster.
:::note warning
:::warning
Ensure that you prepare and migrate any non-Rancher workloads off of the cluster before you destroy the cluster. These resources are nonrecoverable.
:::