Chore: reintroduce type assertion test + change emitted metric names … (#51421)

* Chore: reintroduce type assertion test + change emitted metric names (#51375)

* reintroduce type assertion test + change emitted metric names

* rename test to better eslint to be more generic

(cherry picked from commit 0124dc8e6b)

* don't use --cache

* update betterer results

.betterer.ts

@@ -1,5 +1,16 @@
 import { regexp } from '@betterer/regexp';
+import { eslint } from '@betterer/eslint';
 
 export default {
   'no enzyme tests': () => regexp(/from 'enzyme'/g).include('**/*.test.*'),
+  'better eslint': () =>
+    eslint({
+      '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/consistent-type-assertions': [
+        'error',
+        {
+          assertionStyle: 'never',
+        },
+      ],
+    }).include('**/*.{ts,tsx}'),
 };

package.json

@@ -54,6 +54,7 @@
     "i18n:compile": "lingui compile",
     "postinstall": "husky install",
     "betterer": "betterer",
+    "betterer:merge": "betterer merge",
     "betterer:stats": "ts-node --transpile-only --project ./scripts/cli/tsconfig.json ./scripts/cli/reportBettererStats.ts"
   },
   "grafana": {
@@ -91,6 +92,7 @@
     "@babel/preset-typescript": "7.17.12",
     "@betterer/betterer": "5.3.5",
     "@betterer/cli": "5.3.5",
+    "@betterer/eslint": "5.3.5",
     "@betterer/regexp": "5.3.5",
     "@emotion/eslint-plugin": "11.7.0",
     "@grafana/api-documenter": "7.11.2",

scripts/cli/reportBettererStats.ts

@@ -11,10 +11,23 @@ async function main() {
   const results = await betterer.results();
 
   for (const testResults of results.resultSummaries) {
+    const countByMessage = {};
     const name = camelCase(testResults.name);
-    const count = Object.values(testResults.details).flatMap((v) => v).length;
+    Object.values(testResults.details)
+      .flatMap((v) => v)
+      .forEach((detail) => {
+        const message = camelCase(detail.message);
+        const metricName = `${name}_${message}`;
+        if (metricName in countByMessage) {
+          countByMessage[metricName]++;
+        } else {
+          countByMessage[metricName] = 1;
+        }
+      });
 
-    logStat(name, count);
+    for (const [metricName, count] of Object.entries<number>(countByMessage)) {
+      logStat(metricName, count);
+    }
   }
 }
 

yarn.lock

@@ -3072,6 +3072,19 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@betterer/eslint@npm:5.3.5":
+  version: 5.3.5
+  resolution: "@betterer/eslint@npm:5.3.5"
+  dependencies:
+    "@betterer/betterer": ^5.3.5
+    "@betterer/errors": ^5.3.0
+    tslib: ^2.3.1
+  peerDependencies:
+    eslint: ">=7.0.0"
+  checksum: 5a225c43de7fd87542476b2432b990bdea4552d6264f0ad34ac6873f9643ec4e9f21261288e0d9d0927248a4470d6a4e786b4567c68a526d8833b8b9dc467e2f
+  languageName: node
+  linkType: hard
+
 "@betterer/logger@npm:^5.3.4":
   version: 5.3.4
   resolution: "@betterer/logger@npm:5.3.4"
@@ -19423,6 +19436,7 @@ __metadata:
     "@babel/preset-typescript": 7.17.12
     "@betterer/betterer": 5.3.5
     "@betterer/cli": 5.3.5
+    "@betterer/eslint": 5.3.5
     "@betterer/regexp": 5.3.5
     "@emotion/css": 11.9.0
     "@emotion/eslint-plugin": 11.7.0