public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prometheus: Fix query editor crash in response to invalid query (#94421)

Browse Source 
* Quick fix for RenderParams Function

* Removing unnecessary optional chaining

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

* Removing unittests for RenderParams

---------

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>
This commit is contained in:
Luis Rodrigues
2024-11-05 10:29:52 -05:00
committed by GitHub
co-authored by Nick Richmond
parent c05bfdf71f
commit bfa1f03315
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/grafana-prometheus/src/querybuilder/operationUtils.ts
+2 -2
View File
@@ -96,8 +96,8 @@ export function rangeRendererLeftWithParams(
function renderParams(model: QueryBuilderOperation, def: QueryBuilderOperationDef, innerExpr: string) {
return (model.params ?? []).map((value, index) => {
const paramDef = def.params[index];
if (paramDef.type === 'string') {
return '"' + value + '"';
if (paramDef?.type === 'string') {
return `"${value}"`;
}
return value;