remove mysqlAnsiQuotes FF
This commit is contained in:
@@ -71,10 +71,6 @@ export interface FeatureToggles {
|
||||
*/
|
||||
showDashboardValidationWarnings?: boolean;
|
||||
/**
|
||||
* Use double quotes to escape keyword in a MySQL query
|
||||
*/
|
||||
mysqlAnsiQuotes?: boolean;
|
||||
/**
|
||||
* Rule backtesting API for alerting
|
||||
*/
|
||||
alertingBacktesting?: boolean;
|
||||
|
||||
@@ -104,12 +104,6 @@ var (
|
||||
Stage: FeatureStageExperimental,
|
||||
Owner: grafanaDashboardsSquad,
|
||||
},
|
||||
{
|
||||
Name: "mysqlAnsiQuotes",
|
||||
Description: "Use double quotes to escape keyword in a MySQL query",
|
||||
Stage: FeatureStageExperimental,
|
||||
Owner: grafanaSearchAndStorageSquad,
|
||||
},
|
||||
{
|
||||
Name: "alertingBacktesting",
|
||||
Description: "Rule backtesting API for alerting",
|
||||
|
||||
Generated
-1
@@ -11,7 +11,6 @@ logRequestsInstrumentedAsUnknown,experimental,@grafana/grafana-backend-group,fal
|
||||
grpcServer,preview,@grafana/search-and-storage,false,false,false
|
||||
cloudWatchCrossAccountQuerying,GA,@grafana/aws-datasources,false,false,false
|
||||
showDashboardValidationWarnings,experimental,@grafana/dashboards-squad,false,false,false
|
||||
mysqlAnsiQuotes,experimental,@grafana/search-and-storage,false,false,false
|
||||
alertingBacktesting,experimental,@grafana/alerting-squad,false,false,false
|
||||
logsContextDatasourceUi,GA,@grafana/observability-logs,false,false,true
|
||||
lokiShardSplitting,experimental,@grafana/observability-logs,false,false,true
|
||||
|
||||
|
Generated
-4
@@ -55,10 +55,6 @@ const (
|
||||
// Show warnings when dashboards do not validate against the schema
|
||||
FlagShowDashboardValidationWarnings = "showDashboardValidationWarnings"
|
||||
|
||||
// FlagMysqlAnsiQuotes
|
||||
// Use double quotes to escape keyword in a MySQL query
|
||||
FlagMysqlAnsiQuotes = "mysqlAnsiQuotes"
|
||||
|
||||
// FlagAlertingBacktesting
|
||||
// Rule backtesting API for alerting
|
||||
FlagAlertingBacktesting = "alertingBacktesting"
|
||||
|
||||
+2
-1
@@ -2743,7 +2743,8 @@
|
||||
"metadata": {
|
||||
"name": "mysqlAnsiQuotes",
|
||||
"resourceVersion": "1753448760331",
|
||||
"creationTimestamp": "2022-10-12T11:43:35Z"
|
||||
"creationTimestamp": "2022-10-12T11:43:35Z",
|
||||
"deletionTimestamp": "2025-11-18T19:38:17Z"
|
||||
},
|
||||
"spec": {
|
||||
"description": "Use double quotes to escape keyword in a MySQL query",
|
||||
|
||||
@@ -166,11 +166,7 @@ func (dbCfg *DatabaseConfig) buildConnectionString(cfg *setting.Cfg, features fe
|
||||
cnnstr += fmt.Sprintf("&transaction_isolation=%s", val)
|
||||
}
|
||||
|
||||
//nolint:staticcheck // not yet migrated to OpenFeature
|
||||
if features != nil && features.IsEnabledGlobally(featuremgmt.FlagMysqlAnsiQuotes) {
|
||||
cnnstr += "&sql_mode='ANSI_QUOTES'"
|
||||
}
|
||||
|
||||
cnnstr += "&sql_mode='ANSI_QUOTES'"
|
||||
cnnstr += buildExtraConnectionString('&', dbCfg.UrlQueryParams)
|
||||
case migrator.Postgres:
|
||||
addr, err := util.SplitHostPortDefault(dbCfg.Host, "127.0.0.1", "5432")
|
||||
|
||||
@@ -100,7 +100,7 @@ var databaseConfigTestCases = []databaseConfigTest{
|
||||
name: "MySQL with ANSI_QUOTES mode",
|
||||
dbType: "mysql",
|
||||
dbHost: "[::1]",
|
||||
features: featuremgmt.WithFeatures(featuremgmt.FlagMysqlAnsiQuotes),
|
||||
features: featuremgmt.WithFeatures(),
|
||||
expConnStr: ":@tcp([::1])/test_db?collation=utf8mb4_unicode_ci&allowNativePasswords=true&clientFoundRows=true&parseTime=true&sql_mode='ANSI_QUOTES'",
|
||||
},
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user