Commit Graph
57819 Commits
Author SHA1 Message Date
Jean-Philippe Quéméner 08994304d8 fix(unified-storage): check resource_api cfg for isHA (#102283) 2025-03-18 12:33:27 +01:00
Konrad LalikandGilles De Mey 321a886b8b Alerting: Add details and edit pages for groups (#100884)
* Add basic details page for groups

* Remove unused imports

* Add basic edit page for groups

* Add functional group details page

* Improve form, add namespaces for DS groups

* Add support for multiple actions in useProduceNewRuleGroup

* Attach real actions to form submit

* Add tests for the group details page

* Add basic tests for the group edit page

* Add tests for Mimir update

* Add rule group consistency check

* Extract draggable rules table to a separate file

* Add prom consistency waiting after group saving

* Add duration measure for Prometheus reconciliation time

* Remove a blinking error when redirecting to a new group

* Improve group details page. Use ruler or prom api depending on the ds capabilities

* Add group delete action for DMA

* Fix GroupDetailsPage tests

* Update tests

* Add and improve Edit page tests

* Add Group export for GMA groups

* Fix RulesGroup tests, add translations

* Disable editing plugin provided groups

* Fix alertingApi options, fix tests

* Fix lint errors, update translations

* use name for grafana managed recording rules

* add namespace to nav

* Remove group modals from the list page

* add cancel button to edit form

* add test for cancel butotn

* fix recording rule badge for Grafana managed rules

* Add doc comments, improve code

* Move url changes to be the last action in form submit

* Add returnTo URL handling for alert rule group navigation

* Create dedicated Title component showing breadcrumb navigation between folder
and group name.

Add label distinction between folders and namespaces based on
the rule source (Grafana vs external).

* Address PR feedback, minor refactorings

* Update rule group links to include return path and refactor rule type checks

- Modified `RulesGroup` and `GroupDetailsPage` components to include `includeReturnTo` in edit page links.
- Refactored rule type checks in `DraggableRulesTable` and `GroupDetailsPage` to use `rulerRuleType` for better clarity and maintainability.
- Updated documentation in `useUpdateRuleGroup` to clarify functionality for updating or moving rule groups.

* Refactor RulesGroup component and tests for improved link handling and permissions checks

- Added `includeReturnTo` parameter to rule group detail links in `RulesGroup` for better navigation.
- Updated test cases to verify rendering of edit and view buttons based on user permissions.
- Simplified test setup by removing unnecessary Redux provider wrapping in tests.

* Refactor: Update routing and test assertions in GroupDetails and GroupEdit pages

- Modified route paths in GroupDetailsPage and GroupEditPage tests to use `dataSourceUid` instead of `sourceId`.
- Updated test assertions to reflect changes in folder title and link structure in GroupDetailsPage.
- Simplified Title component by removing folder-related props and logic, focusing solely on the group name.

* Refactor: Simplify Title rendering in GroupDetailsPage

- Updated the renderTitle function in GroupDetailsPage to remove the folder prop from the Title component, focusing solely on the group name.

* Update GroupDetailsPage to prevent editing of provisioned groups

* Fix imports

* Improve styles

* Fix navigation when served from subpath

* Improve group removal handling in Prom consistency check. Fix Delete group button

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2025-03-18 12:27:53 +01:00
Eric LeijonmarckandGabriel MABILLE fc9e5110d7 Access: Add migration to remove datasources:drilldown (#102188)
* Add migration to remove datasources:drilldown

* remove role assignments as well

* rename to datasources:drilldown

* remove the role assignments

* made it simple instead

* Update pkg/services/sqlstore/migrations/accesscontrol/datasource_drilldown_removal.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

* Update pkg/services/sqlstore/migrations/accesscontrol/datasource_drilldown_removal.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2025-03-18 13:06:30 +02:00
Stephanie Hingtgen c79c768421 Folders: Add pagination to list (#102334) 2025-03-18 04:56:06 -06:00
Oscar Kilhed ba44ceb4b2 Dynamic dashboards: Add paste panel option to add pane (#102350)
* Add paste panel to side pane, unify Store class, subscribe to storage events

* i18n
2025-03-18 11:49:33 +01:00
linomanandIrene Rodriguez afb058c40a Fix URL rendering typo (#102346)
* Fix URL rendering typo

* run prettier

---------

Co-authored-by: Irene Rodriguez <irene.rodriguez@grafana.com>
2025-03-18 11:42:25 +01:00
Alexander Akhmetov 695ac91290 Alerting: Add backend support for keep_firing_for (#100750)
What is this feature?

This PR introduces a new alert rule configuration option, keep_firing_for (Prometheus documentation).

keep_firing_for prevents alerts from resolving immediately after the alert condition returns to normal. Instead, they transition into a "Recovering" state and are not considered resolved by the Alertmanager. Once the recovery period ends (or after the next evaluation if it is bigger than keep_firing_for), the alert transitions to "Normal" if it doesn't start alerting again:

Before                                          

+----------+     +----------+                    
| Alerting |---->|  Normal  |                    
+----------+     +----------+                    

-----
After

+----------+      +------------+     +----------+
| Alerting |----->| Recovering |---->|  Normal  |
+----------+      +------------+     +----------+                                                 

Why do we need this feature?

This feature prevents flapping alerts by adding a recovery period. This helps avoid false resolutions caused by brief alert
2025-03-18 11:24:48 +01:00
Alexander Akhmetov 9491fa1895 Alerting: Add an index to alert_rule_version table on (rule_org_id, rule_uid) (#102347) 2025-03-18 11:15:55 +01:00
Alexander Akhmetov 1d0a86252e Alerting: Add target datasource support to Prometheus conversion (#102307) 2025-03-18 09:53:50 +01:00
Tom Ratcliffe e14b2fa034 Chore: Add descriptions to frontend types for feature toggle generation (#102230)
Add descriptions to frontend types for feature toggle generation
2025-03-18 09:20:47 +02:00
Alex Khomenko 3454030bc2 Provisioning: Add dashboard preview banner (#102305)
* Provisioned: Add dashboard preview banner

* Add translations

* Add banner to the dashboard page

* Add translations

* Add feature toggle
2025-03-18 08:55:25 +02:00
dependabot[bot]andgithub-actions[bot] 967425ab1b Bump github.com/expr-lang/expr from 1.16.9 to 1.17.0 in /pkg/codegen (#102333)
* Bump github.com/expr-lang/expr from 1.16.9 to 1.17.0 in /pkg/codegen

Bumps [github.com/expr-lang/expr](https://github.com/expr-lang/expr) from 1.16.9 to 1.17.0.
- [Release notes](https://github.com/expr-lang/expr/releases)
- [Commits](https://github.com/expr-lang/expr/compare/v1.16.9...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/expr-lang/expr
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* update workspace

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-03-18 09:49:03 +03:00
Alex Khomenko 20fcf443f8 Dashboard: Disable creating library panels for provisioned dashboards (#102308) 2025-03-18 07:29:52 +02:00
Leon Sorokin 1a6ec71822 Transformations: Fix field naming in Add field from calc (Binary mode) (#102331) 2025-03-18 02:39:47 +02:00
Leon Sorokin afd6326d0c Chore: uPlot v1.6.32 (#102149) 2025-03-17 19:35:11 -05:00
grafana-pr-automation[bot]andgithub-actions[bot] 2801c38eba I18n: Download translations from Crowdin (#102332)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-03-18 02:30:31 +02:00
Stephanie Hingtgen 4755da0ff5 Folders: Fix user setting in api (#102329) 2025-03-17 18:33:09 -05:00
owensmallwood c45a342303 Unified Storage Dashboard Provisioning: Wait for deleted dashboards to be updated in the indexer (#102243)
* wait for deleted dashboards to be updated in the indexer

* updates comment

* adds test

* make function private

* fix failing test - had to add a couple more mock Search calls
2025-03-17 16:46:26 -06:00
Dominik Broj f7e0f095a2 Alerting: use 'Grafana IRM' wording in alerting contact point (#102014)
* chore: use 'Grafana IRM' wording in alerting contact point

* revert temp condition change

* remove unneeded ts assertion

* more renaming

* use translations

* update test

* running make i18n-extract

* avoid "simple" word in copy
2025-03-17 23:38:44 +02:00
Sven Grossmann 8297c0f34e prom: fix sorting in fetchLabels (#102318)
* fix(prom): return label keys from prometheus language providers

* fix: only sort once

* fix: lose reference
2025-03-17 23:26:42 +02:00
ismail simsek 07024c9bac Prometheus: Enable prometheusRunQueriesInParallel feature toggle by default (#102127)
enable prometheusRunQueriesInParallel by default
2025-03-17 22:13:59 +01:00
Stephanie Hingtgen 6019b21cc5 K8s: Dashboards: Fix multi-org provisioning flow (#102266) 2025-03-17 20:20:03 +02:00
Dzmitry Kozhukh 250cdbcd1a GrafanaUI: prevent ToolbarButton from submitting wrapping form (#102228)
fix(grafana-ui): prevent toolbar button from submitting wrapping form
2025-03-17 17:13:54 +00:00
Ryan McKinley fd4e08e318 K8s/Dashboards: Remove slug annotation (#102270) 2025-03-17 19:01:29 +02:00
Ryan McKinley 261d7db0e6 Live: Update centrifuge and remove unreleased "gitops" (#102256) 2025-03-17 18:55:00 +02:00
Ashley Harrison 2ece94bc50 Chore: Fix pseudo translations (#102295)
* remove unnecessary pseudo translations

* properly initialise pseudo translations in core (not grafana-ui)
2025-03-17 16:45:36 +00:00
beejeebus 3bdb2aa349 Plugins: Fix support for adhoc filters with raw queries in InfluxDB (#101966)
Plugins: Fix support for adhoc filters with raw queries in InfluxDB

Fixes #101635.
2025-03-17 12:07:33 -04:00
Jev Forsberg 83c3c01769 Chore: Migrate pr-swagger-gen from Drone to GHAs (#102157)
* baldm0mma/ update swagger step

* baldm0mma/ update with correct wire tags

* baldm0mma/ add write token permissions

* baldm0mma/ make swagger-clean && make openapi3-gen

* baldm0mma/ remove wire_tags

* Reset OpenAPI specs to main branch version

* baldm0mma/ regen specs with enterprise running

* baldm0mma/ test go version issue

* baldm0mma/ test with building with go 1.24.1

* baldm0mma/ add comment
2025-03-17 09:28:24 -06:00
Gábor Farkas 4302fec311 removed unused file (#102281) 2025-03-17 16:27:13 +01:00
Sven Grossmann 8140c19bbd fix(prom): return label keys from prometheus language providers (#102294) 2025-03-17 16:15:38 +01:00
Kevin Minehart ebb3902307 CI: remove frontend unit test and frontend linting from drone PR/main pipelines (#102221)
* remove frontend unit test and frontend linting from drone PR/main pipelines

* remove unused dependency on frontend test

* fail fast on frontend unit tests

* no more main-test-frontend

* update CODEOWNERS

* make job names more identifiable
2025-03-17 09:41:17 -05:00
Igor Suleymanovandleonorfmartins 424a178d96 Update dependencies for Grafana submodules (#102296)
* Update dependencies for Grafana submodules

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

* Update workspace

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

* Update owners

* Fix code owners of the dependency

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

---------

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>
Co-authored-by: leonorfmartins <leonorfmartins@gmail.com>
2025-03-17 16:23:57 +02:00
Alex Khomenko 71cee10cb6 Provisioning: Add dashboard saving functionality (#102269)
* Move dashboard-scene, provisioned dashboard features, and dashboard services/types from grafana-git-ui-sync branch

* Merge

* Update props order

* Fix imports

* Fix imports

* Update dashboard page

* Update imports

* Update test

* Tweaks

* Remove extra mocks

* Split out utils

* Translate

* Revert

* Add translations

* Add comment

* Prettier

* Add comment

* Use AnnoKeyManagerIdentity

* Add manager kind
2025-03-17 16:15:41 +02:00
Konrad Lalik b11daf57bb Alerting: Fix rule instances table (#102290)
Fix the condition for displaying alert instances table in RuleDetails component
2025-03-17 15:09:52 +01:00
Peter Štibraný 11552e5c57 Speed up truncation of Spanner tables (used in integration tests) (#102278)
Speed up truncation of Spanner tables.
2025-03-17 15:05:01 +01:00
Igor Suleymanov 3f270d1de0 K8s/Dashboards: Fix panics in Dashboards v2alpha1 API (#102123)
* K8s/Dashboards: Fix panics in Dashboards v2alpha1 API

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

* Update generated code to use the `MappingType` properly

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

---------

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>
2025-03-17 15:04:11 +02:00
Tom Ratcliffe f1470de478 Chore: Add eslint rule for empty files and tidy up (#102288)
* Add eslint rule for empty files

* Remove empty files
2025-03-17 14:54:12 +02:00
Torkel Ödegaard 74705bd5b3 Dashboard: New UX for switching layouts (#102268)
* Layout switching

* Update

* Update

* Update

* Update

* Update

* unline styles

* fixing lint issue
2025-03-17 13:50:34 +01:00
Ashley Harrison 2b3a36b572 Query library: Add selectors and turn on feature toggle in e2e (#101347)
* add selectors and turn on feature toggle in e2e

* remove unneeded feature toggle
2025-03-17 12:31:22 +00:00
Ashley Harrison d82a877f65 GrafanaUI: Mark up or ignore remaining grafana-ui translations (#102203)
* markup or ignore remaining grafana-ui translations

* fix unit tests, commit betterer results which somehow didn't get autocommitted?! :o

* fix SharedPreferences unit test

* fix remaining unit tests

* fix azure e2e test

* better solution
2025-03-17 12:27:40 +00:00
Jack Westbrook 5cd8547131 Revert "Grafana Data: Use package.json exports for internal code (#102286)
Revert "Grafana Data: Use package.json exports for internal code (#102036)"

This reverts commit 91116de790.
2025-03-17 12:26:59 +00:00
Ryan McKinley c46565f652 K8s/Dashboard: DeepCopy should deep copy (#102258) 2025-03-17 14:29:18 +03:00
Jean-Philippe Quéméner 1700a8aa9f feat(unified-storage): prune history table based on limits (#101970) 2025-03-17 11:36:38 +01:00
Pepe Cano cacdf00067 alerting(ui): add external links to read more about labels and annotations (#102187)
* alerting(ui): add external link to read about labels

* alerting(ui): add external link to read about annotations

* fix i18n settings

* fix i18n

* fix i18n error with `make 18n-extract`
2025-03-17 11:28:29 +01:00
Jack Westbrook 91116de790 Grafana Data: Use package.json exports for internal code (#102036)
* refactor(frontend): rename all @grafana/data/src imports to @grafana/data

* feat(grafana-data): introduce internal entrypoint for sharing code only with grafana

* feat(grafana-data): add test entrypoint for data test utils usage in core

* refactor(frontend): update import paths to use grafana/data exports entrypoints

* docs(grafana-data): update comment in internal/index.ts

* refactor(frontend): prefer public namespaced exports over re-exporting via internal
2025-03-17 11:27:17 +01:00
Timur Olzhabayev f2518a2c45 Chore: Promote pluginsDetailsRightPanel to private preview (#102211)
promote FeatureStagePrivatePreview to private preview
2025-03-17 10:49:51 +01:00
Peter Štibraný 3ec3085416 Pass build tags to golangci-lint and go test commands. (#102206)
* Pass build tag to golangci-lint.

* Pass build tags to go test command.
2025-03-17 10:47:27 +01:00
aishyandapalli 3e5975367c Prometheus: Add SpanID while clicking on TraceID datalink for Exemplar (#101541)
Add Span context to Exemplar data links
2025-03-17 10:14:55 +01:00
Denis Vodopianov de6a48a233 Chore: Replace bingo-managed tools with go tool directive. (#101890) 2025-03-17 09:48:41 +01:00
Peter Štibraný 077f9e90d5 Fix format of timestamps sent to Spanner. (#102227) 2025-03-17 09:27:11 +01:00