Commit Graph

58632 Commits

Author SHA1 Message Date
Peter Štibraný be696dd70c unified storage: check for iterator errors after each call to iter.Next. (#102804)
* unified storage: check for iterator errors after each call to iter.Next.
* Extracted test to separate method, add 500 events before listing.
2025-04-11 16:25:40 +02:00
Oscar Kilhed 782fa5b45a Dynamic dashboards: Fix issue where tab content is not visible (#103890)
* only wrap in edit mode

* fix icon
2025-04-11 16:13:16 +02:00
Isabel Matwawana eede2b78b4 Docs: datagrid visualization refactor (#103832) 2025-04-11 10:13:03 -04:00
Alexander Akhmetov babea87ebd Chore: make update-workspace (#103888) 2025-04-11 16:06:54 +02:00
Ivan Ortega Alba eb70d23e44 Dashboards: Create dashboard with the correct apiVersion (#103839) 2025-04-11 14:03:24 +00:00
Vardan Torosyan 2a6736aae3 Docs: Clarify how authNZ works when SCIM is enabled (#103857)
* Docs: Clarify how authNZ works when SCIM is enabled

* Use Grafana Cloud instead of grafana.com
2025-04-11 13:54:52 +00:00
Johnny Kartheiser e9643366b3 alerting docs: update alert rules history limit documentation (#102838)
* alerting docs: update alert rules history limit documentation

the documentation for the alert rules version history has been updatedto specify that the rules apply to enterprise/OSS customers.
the rules should also be explicated for cloud documentation.

* Update view-alert-rules.md
2025-04-11 08:43:46 -05:00
Tom Ratcliffe 23f97697a3 Alerting: Remove comment references to angular in tests (#103878) 2025-04-11 15:43:11 +02:00
Peter Štibraný b8691c4797 spanner: Fix use of in-memory sequence generator (#103767) 2025-04-11 15:42:58 +02:00
Agnès Toulet d7c554c25e Renderer: Fix regression on callback URL in plugin mode (#103787)
* Renderer: Fix regression on callback URL in plugin mode

* cleanup

* refactor to not mutate cfg object

* apply review feedback
2025-04-11 15:34:10 +02:00
Johnny Kartheiser f1625d9e56 docs: docs for "Permanently delete" feature for alert rules (#103409)
* documentation on permanently deleting alert rules

document the new Delete permanently feature.

* Update create-grafana-managed-rule.md

uuid detail

* Update create-grafana-managed-rule.md

* Update create-grafana-managed-rule.md

vale

* Update docs/sources/alerting/alerting-rules/create-grafana-managed-rule.md

thanks pepe

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

---------

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>
2025-04-11 08:29:27 -05:00
Sergej-Vlasov ae867469a5 DashboardEditPane: Get original panel id for repeated panel edit pane (#103877)
get original panel id for repeated panel edit pane
2025-04-11 14:28:54 +01:00
Matthew Jacobson 9f9c4b3da3 Alerting: Template preview enhancements (#103817)
API Changes:

- Fixes validation in template CRUD API to be closer to how the running 
  alertmanager will use the template. Should remove some incorrect 
  validation errors.

- Adds some missing default placeholder labels to receiver testing that 
  are used during template testing but missing during receiver testing


Template Preview:

- Replaced basic preview with a readonly CodeEditor for better whitespace 
  and alignment clarity (also adds support for future syntax highlighting 
  in template previews for upcoming webhook payload templates)

Template Selector (Receiver Form):

- Refactored to use same components as Template editor for preview.
- Fixed preview to work with multi-definition templates
- Fixed copy to correctly copy the template contents instead of 
  {{ template "<name>" . }}.

Template Editor:

- Fixed detection of when to display functions vs snippets in multi-line 
  expressions
2025-04-11 09:27:19 -04:00
Ryan McKinley 2c3422fc5c Provisioning: return field paths in test error messages (#103850)
* Provisioning: Do not block connect step on error

* Display field errors

* Cleanup

* return field errors

* fix test

* convert errros to an array

* Fix history display

* Add getFormErrors

* metav1 issues

* lint

* Proper field names

* Fix notification

* Remove unused component

---------

Co-authored-by: Clarity-89 <homes89@ukr.net>
2025-04-11 14:26:42 +01:00
Tom Ratcliffe ed9a7e8d9f Alerting: Make nested folders work in Alert List Panel (#103550) 2025-04-11 14:24:53 +01:00
Sven Grossmann e7b32d6229 Extension Sidebar Button: Prevent button to have stretched background (#103882) 2025-04-11 14:18:46 +01:00
Stephanie Hingtgen 88391b173e K8s: Enable kubernetesClientDashboardsFolders by default (#103843) 2025-04-11 07:56:05 -05:00
Alex Khomenko 1291b60bbe Checkbox: Add z-index to description (#103847)
* Checkbox: Add z-index to description

* Add comment
2025-04-11 15:32:02 +03:00
Stephanie Hingtgen f5ad1ef69b K8s: Folders: Add v1 api (#103842) 2025-04-11 13:09:52 +01:00
Oscar Kilhed 50499fa749 Dashboards: Add a config setting that limits the number of series that will be displayed in a panel. Users can opt in to render all series. (#103405)
* Limit series in panels in dashboards

* fix mangled comment
2025-04-11 13:56:58 +02:00
Alex Spencer 906004c7ae TableNg: Fix a few bugs found in K8s land (#103829)
* fix: a few bugs found in K8s land

* fix: column width buggy behavior

* fix: column width try again
2025-04-11 05:47:40 -06:00
ismail simsek 962232c31c Prometheus: Add ability to clear metric name in PromQL query builder (#103821)
is clearable true
2025-04-11 13:39:11 +02:00
Bogdan Matei 35e78feffa Dynamic Dashboards: Add repeats for tabs (#103348) 2025-04-11 13:50:44 +03:00
Sergej-Vlasov 9b6021c490 AutoGridLayoutManager: Fix viz panel key duplication in auto and custom layouts (#103727)
* fix  viz panel key duplication in auto and custom layouts

* clean up
2025-04-11 11:17:32 +01:00
Andres Martinez Gotor 335a55047b Advisor: Move the missing plugin check to its own step (#103861) 2025-04-11 12:11:05 +02:00
Ryan McKinley 0d20680695 Provisioning: Improve PR feedback (#103537)
* fix ref

* dryRun before save

* reuse code for create vs update

* update comments

* can update PRs

* return useful errors

* update preview links

* lint fix

* update some wording

* update mocks

* fixed

* Update pkg/registry/apis/provisioning/resources/dualwriter.go

Co-authored-by: Roberto Jiménez Sánchez <roberto.jimenez@grafana.com>

* more updates

* fix link

* error string

* dry run

* refactor galore

* with template test

* very basic tests

* more test cases

* remove generator

* more tests

* fix lint

* multiple files now

* merge main

* merge main

* fix snapshots

* fix snapshots

* slugify title

---------

Co-authored-by: Roberto Jiménez Sánchez <roberto.jimenez@grafana.com>
2025-04-11 11:06:16 +01:00
Alexa V 00dcf482cf Dashboard -Schema V2 Stateless annotations (dsRef independent) (#102949)
* Implement basic behavior of stateless annotation

* Fix ds defined getting lost

* Fix linter

* adjust test to be aligned with datasources not automatically being assigned to the model

* Add  unit test for annotations

---------

Co-authored-by: Haris Rozajac <58232930+harisrozajac@users.noreply.github.com>
Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>
2025-04-11 11:42:48 +02:00
Andres Martinez Gotor 8ebce76535 UserStorage: multiple improvements (#103779) 2025-04-11 11:32:31 +02:00
Laura Fernández 3607356f65 i18n: Update internationalization/dates.ts to use locale (#103731) 2025-04-11 11:24:40 +02:00
grafana-pr-automation[bot] c303cd3a8b I18n: Download translations from Crowdin (#103840)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-04-11 09:55:12 +01:00
Peter Štibraný b0b4b31765 publicdashboards: Don't format timestamp before passing it to database. (#103463)
Don't format timestamp before passing it to database.
2025-04-11 10:31:10 +02:00
Peter Štibraný 54b8dde1e1 services/user: Fix userimpl tests when running on Spanner. (#103715)
Fix userimpl tests when running on Spanner.
2025-04-11 10:28:21 +02:00
Sergej-Vlasov 4648ba396b DashboardScenePage: Correct slug in self referencing data links (#100048)
* switch to useLayoutEffect so queries run after url correction

* add comment

* suparate useEffects to avoid update on slug change

* add url correction for missing slug

* account for slug change during dashboard rename

* simplify fix

* add e2e test for data link without slug

* remove old comment

* remove newly added path from useEffect dependencies
2025-04-11 09:25:21 +01:00
Ashley Harrison 79400018a4 Preferences: Allow setting lang and theme from URL (#103587)
* allow setting theme/language via url

* set in backend instead

* add locale as well
2025-04-11 09:21:06 +01:00
Jean-Philippe Quéméner 50fcc053c2 feat(unified-storage): provide delete function for bucket (#103825) 2025-04-11 10:10:13 +02:00
Gabriel MABILLE 45d6bfe7cf AuthZ: Make cache ttl configurable (#103769)
* AuthZ: Configure cache ttl

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>

* Client side conf

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>

* 0 -> No caching

* Make it possible to disable cache on the remote client as well

* Comment

* Move ttl parsing up for in-proc to have it

---------

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
2025-04-11 10:09:47 +02:00
Konrad Lalik 0a8dccc19a Alerting: New alert list filter improvements (#103107)
* Move filtering code to generators for performance reasons

Discarding rules and groups early in the iterable chain limits the number of promises we need to wait for which improves performance significantly

* Add error handling for generators

* Add support for data source filter for GMA rules

* search WIP fix

* Fix datasource filter

* Move filtering back to filtered rules hook, use paged groups for improved performance

* Add queriedDatasources field to grafana managed rules and update filtering logic to rely on it

- Introduced a new field `queriedDatasources` in the AlertingRule struct to track data sources used in rules.
- Updated the Prometheus API to populate `queriedDatasources` when creating alerting rules.
- Modified filtering logic in the ruleFilter function to utilize the new `queriedDatasources` field for improved data source matching.
- Adjusted related tests to reflect changes in rule structure and filtering behavior.

* Add FilterView performance logging

* Improve GMA Prometheus types, rename queried datasources property

* Use custom generator helpers for flattening and filtering rule groups

* Fix lint errors, add missing translations

* Revert test condition

* Refactor api prom changes

* Fix lint errors

* Update backend tests

* Refactor rule list components to improve error handling and data source management

- Enhanced error handling in FilterViewResults by logging errors before returning an empty iterable.
- Simplified conditional rendering in GrafanaRuleLoader for better readability.
- Updated data source handling in PaginatedDataSourceLoader and PaginatedGrafanaLoader to use new individual rule group generator.
- Renamed toPageless function to toIndividualRuleGroups for clarity in prometheusGroupsGenerator.
- Improved filtering logic in useFilteredRulesIterator to utilize a dedicated function for data source type validation.
- Added isRulesDataSourceType utility function for better data source type checks.
- Removed commented-out code in PromRuleDTOBase for cleaner interface definition.

* Fix abort controller on FilterView

* Improve generators filtering

* fix abort controller

* refactor cancelSearch

* make states exclusive

* Load full page in one loadResultPage call

* Update tests, update translations

* Refactor filter status into separate component

* hoist hook

* Use the new function for supported rules source type

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2025-04-11 10:02:34 +02:00
Torkel Ödegaard 1e669cbb45 AppChrome: Sidebar extensions button update (#103791)
* AppChrome: Sidebar app icon button update

* Update

* remove unused files

* Update public/app/core/components/AppChrome/ExtensionSidebar/ExtensionToolbarItem.tsx

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>

* update

---------

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2025-04-11 09:25:09 +02:00
Alex Khomenko 04fae8bd46 Provisioning: Update ConfigForm (#103846)
* Provisioning: Fix token permissions alignment

* Update config form

* Extract getDefaultValues
2025-04-11 08:33:11 +03:00
Andreas Christou 7aa8628971 AzureMonitor: Only fetch table plans in the builder (#103833)
* Only fetch table plans in the builder

* Appropriately set schema
2025-04-11 01:31:45 +01:00
Moustafa Baiou 032299011a Alerting: Relax permissions for access a rule (#103664)
This makes it so that it is:
- No longer required to have datasource permissions to delete a rule.
- No longer required to have datasource permissions to update non-query related fields of a rule.
2025-04-11 00:58:37 +01:00
Andreas Christou 3a71a48a88 AzureMonitor: Improve selection of Basic Logs tables in the query builder (#103820)
* Add function for retrieving logs table plan

- Add URL builder method
- Add types

* Add auto-switching for basic logs tables

* Set dashboardTime property

* Ensure useEffect doesn't run on every query change

* Fix basicLogs property

* Add isLoading for schema
2025-04-10 14:11:00 -06:00
Sven Grossmann 05338838b0 Sidecar: Remove experimental Sidecar implementation (#103786)
* Sidecar: remove `appSidecar` feature toggle

* Sidecar: Remove sidecar implementation

* lint
2025-04-10 22:04:12 +02:00
Alex Khomenko 0bad0526f5 Provisioning: Simplify component logic (#103816) 2025-04-10 22:54:56 +03:00
Nick Richmond 73ba19a98e Dashboards: Fix panel link to Grafana Metrics Drilldown (#103759)
* fix: panel link to Grafana Metrics Drilldown

* test: handling of plugin links
2025-04-10 21:50:10 +02:00
Kevin Yu fd6fd91115 Prometheus: Add support for cloud partners Prometheus data sources (#103482)
* wip

* Add prom flavor support for data source variables and export/import dashboards (#103321)

* add dashboard and data source var selection

* use match plugin id instead

* use updated matchpluginid

* formatting

* cleanup

* regex anchor

* update error msg

* Alerting: Clean up prometheus-flavored types and functions (#103703)

* clean up types and utility functions for dealing with
prometheus-flavored data sources

* Refactor alerting datasource types to use constants as source of truth

* Alerting: Clean up prometheus-flavored types and functions on the bac… (#103716)

Alerting: Clean up prometheus-flavored types and functions on the backend

* add matchPluginId tests

* Update matchPluginId func to bidirectional (#103746)

* update matchpluginid func to bidirectional

* lint

* formatting

* use actual isSupportedExternalRulesSourceType in test

* add tests in datasource_srv

* betterer

* remove type assertion

* remove unnecessary case

* use satisifies to not have to convert tuple to an array of string

* add prometheus_flavor test

---------

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: Alexander Akhmetov <me@alx.cx>
2025-04-10 12:49:11 -07:00
Sven Grossmann 22a9e1b5ff Scopes: Fix translation key of scopes.dashboards.toggle.expand (#102515) 2025-04-10 20:37:59 +01:00
Ryan McKinley 02b090574d Unified: use server access client for bulk operations (#103828) 2025-04-10 20:29:59 +01:00
Dana Axinte 190f5a234f Cloud migrations: Update links to docs in cloud stack page (#103789)
* modify links

* new tab links

* remove line
2025-04-10 20:08:00 +01:00
Piotr Jamróz 3551e6074c TraceView: Handle External correlation links correctly (#103594)
* TraceView: Handle External correlation links correctly

* Improve handling URLs
2025-04-10 20:07:49 +01:00